Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

mixxx: 2.2.1 -> 2.2.2 #66715

Merged
merged 1 commit into from Aug 17, 2019
Merged

mixxx: 2.2.1 -> 2.2.2 #66715

merged 1 commit into from Aug 17, 2019

Conversation

matthiasbeyer
Copy link
Contributor

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @haslersn

@haslersn
Copy link
Contributor

I didn't test it, yet, but I can approve that the done changes suffice.

@markuskowa
Copy link
Member

@GrahamcOfBorg build mixxx

@markuskowa
Copy link
Member

builds locally on x86_64-linux and seems to run.

@markuskowa markuskowa merged commit 1d1eee5 into NixOS:master Aug 17, 2019
@matthiasbeyer
Copy link
Contributor Author

Should we backport this to stable?

@matthiasbeyer matthiasbeyer deleted the update-mixxx branch August 23, 2019 11:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cillianderoiste cillianderoiste Awaiting requested review from cillianderoiste

@aszlig aszlig Awaiting requested review from aszlig

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@matthiasbeyer @haslersn @markuskowa