[IntersectionObserver] Use inclusive intersect with remote frame parent #18443
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
approved these changes
Aug 15, 2019
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-1754595
branch
from
8fd53fc
to
fb2bb61
Compare
The rest of the MapToVisualRectInAncestorSpace code will do inclusive intersections when the kEdgeInclusive flag is set, as required by IntersectionObserver to correctly handle zero-area targets. This patch adds coverage for this situation to the existing WPT for cross-origin IntersectionObserver. Since the bug only affects IntersectionObserver running inside an OOPIF, this also updates the test to force the iframe into a different domain, rather than just using the sandbox attribute (which is not sufficient to trigger OOPIF). BUG=978759 Change-Id: I7dbe52d2f3e39e029fed3dda5be31190c593a1e2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1754595 Reviewed-by: Ken Buchanan <kenrb@chromium.org> Commit-Queue: Stefan Zager <szager@chromium.org> Cr-Commit-Position: refs/heads/master@{#687361}
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-1754595
branch
from
fb2bb61
to
fbb5b7d
Compare
|
A flaky result occurred in a renamed test -- the flakiness is most likely pre-existing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The rest of the MapToVisualRectInAncestorSpace code will do inclusive
intersections when the kEdgeInclusive flag is set, as required by
IntersectionObserver to correctly handle zero-area targets.
This patch adds coverage for this situation to the existing WPT for
cross-origin IntersectionObserver. Since the bug only affects
IntersectionObserver running inside an OOPIF, this also updates the
test to force the iframe into a different domain, rather than just
using the sandbox attribute (which is not sufficient to trigger OOPIF).
BUG=978759
Change-Id: I7dbe52d2f3e39e029fed3dda5be31190c593a1e2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1754595
Reviewed-by: Ken Buchanan <kenrb@chromium.org>
Commit-Queue: Stefan Zager <szager@chromium.org>
Cr-Commit-Position: refs/heads/master@{#687361}