Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

apfs-fuse: init at 20190723 #66661

Merged
merged 2 commits into from Aug 16, 2019
Merged

apfs-fuse: init at 20190723 #66661

merged 2 commits into from Aug 16, 2019

Conversation

ealasu
Copy link
Contributor

@ealasu ealasu commented Aug 15, 2019

Motivation for this change

Add apfs-fuse.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

aanderse
aanderse requested changes Aug 15, 2019
View reviewed changes
Copy link
Member

@aanderse aanderse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for choosing to contribute this package to nixpkgs. I have left a few comments I hope you find helpful.

maintainers/maintainer-list.nix Show resolved Hide resolved
pkgs/tools/filesystems/apfs-fuse/default.nix Outdated Show resolved Hide resolved
pkgs/tools/filesystems/apfs-fuse/default.nix Outdated Show resolved Hide resolved
pkgs/tools/filesystems/apfs-fuse/default.nix Outdated Show resolved Hide resolved
pkgs/tools/filesystems/apfs-fuse/default.nix Outdated Show resolved Hide resolved
@ealasu ealasu force-pushed the feature/apfs-fuse branch 2 times, most recently from 1d2304d to fa1e42f Compare August 16, 2019 00:34
@ealasu
Copy link
Contributor Author

ealasu commented Aug 16, 2019

@aanderse Thanks, updated.

@aanderse
Copy link
Member

aanderse commented Aug 16, 2019 •
edited

@GrahamcOfBorg build apfs-fuse

@aanderse aanderse merged commit 63ce6bf into NixOS:master Aug 16, 2019
@aanderse
Copy link
Member

Thanks! 🎉

@ealasu ealasu deleted the feature/apfs-fuse branch August 17, 2019 03:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@symphorien symphorien symphorien left review comments

@aanderse aanderse aanderse approved these changes

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10 11.by: package-maintainer 12. first-time contribution
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@ealasu @aanderse @symphorien @Janik-Haag