Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: NixOS/nixpkgs
base: 2240c5c85885
Choose a base ref
...
head repository: NixOS/nixpkgs
compare: aa99a263cc9d
Choose a head ref
  • 1 commit
  • 1 file changed
  • 1 contributor

Commits on Aug 17, 2019

  1. zlib: Properly clean up static/shared distinction 

    This improves what commit

    e999def zlib: clean up static/shared distincion

described as "kind of a mess" and "confusing". And indeed it was confusing.

Now, the concept whether or not the .a file is moved to a split output
is controlled by a clean variable.

The defaults remain unchanged.

The new approach also finally cleanly allows building statically but NOT
using a split output, like all other autoconf-based projects in nixpkgs do
(using the `dontDisableStatic` setting).
That is important for overlays that want to enable static libs for all
packages in one go, without having to hand-patch idiosynchrasies like zlib
had until now.

Until now, if you wanted the .a in the main output, the only way was to go via
`static=false, shared=true` -- which made no sense, because you had to say
`static=false` even though you want a static lib. That is fixed now.
    @nh2
    nh2 committed Aug 17, 2019
    Copy the full SHA
    aa99a26 View commit details
    Browse the repository at this point in the history