Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

libreoffice-fresh: 6.2.4.2 -> 6.3.0.4 #66756

Merged
merged 1 commit into from Aug 17, 2019
Merged

libreoffice-fresh: 6.2.4.2 -> 6.3.0.4 #66756

merged 1 commit into from Aug 17, 2019

Conversation

AluisioASG
Copy link
Contributor

Motivation for this change

Two changes besides the usual update:

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @7c6f434c

Should this be backported to 19.03 as well?

@ofborg ofborg bot requested a review from 7c6f434c August 17, 2019 14:05
@7c6f434c
Copy link
Member

Thank you!

Re: ZFS failure — if one test is enough, indeed that's not a problem to disable it.

Re: 19.03: I guess updating Fresh in 19.03 to the now-freshest Still (i.e. same minor, latest patchlevel) is a reasonable approach (stable channel getting close to EOL should probably keep the same minor as it is still supported). Still in 19.03 is a better question (but won't be a backport of this PR for sure)…

@7c6f434c 7c6f434c merged commit 9693fd5 into NixOS:master Aug 17, 2019
@AluisioASG AluisioASG deleted the libreoffice-6.3.0.4 branch August 17, 2019 20:00
@AluisioASG AluisioASG mentioned this pull request Aug 18, 2019
Merged
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@7c6f434c 7c6f434c Awaiting requested review from 7c6f434c

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@AluisioASG @7c6f434c