Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

style: Sync changes from mozilla-central. #23973

Merged
merged 33 commits into from Aug 16, 2019
Merged

Conversation

emilio
Copy link
Member

@emilio emilio commented Aug 15, 2019

See each individual commit for details.


This change is Reviewable

@highfive highfive added the S-awaiting-review There is new code that needs to be reviewed. label Aug 15, 2019
@highfive
Copy link

warning Warning warning

  • These commits modify style and layout code, but no tests are modified. Please consider adding a test!

@emilio
Copy link
Member Author

emilio commented Aug 15, 2019

@bors-servo try

@nox: r? for the last commit?

@bors-servo
Copy link
Contributor

⌛ Trying commit 4752110 with merge efccee4...

bors-servo pushed a commit that referenced this pull request Aug 15, 2019
style: Sync changes from mozilla-central.

See each individual commit for details.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/23973)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

💔 Test failed - linux-rel-css

@highfive highfive added the S-tests-failed The changes caused existing tests to fail. label Aug 15, 2019
@emilio
Copy link
Member Author

emilio commented Aug 15, 2019

@bors-servo r=emilio,jdm

@bors-servo
Copy link
Contributor

📌 Commit 4752110 has been approved by emilio,jdm

@highfive highfive assigned emilio and unassigned paulrouget Aug 15, 2019
@highfive highfive added S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. and removed S-awaiting-review There is new code that needs to be reviewed. S-tests-failed The changes caused existing tests to fail. labels Aug 15, 2019
@bors-servo
Copy link
Contributor

⌛ Testing commit 4752110 with merge aac78a3...

bors-servo pushed a commit that referenced this pull request Aug 15, 2019
style: Sync changes from mozilla-central.

See each individual commit for details.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/23973)
<!-- Reviewable:end -->
@highfive highfive added S-awaiting-review There is new code that needs to be reviewed. and removed S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. labels Aug 15, 2019
@emilio
Copy link
Member Author

emilio commented Aug 15, 2019

@bors-servo r=emilio,jdm

  • Updated test expectations

@bors-servo
Copy link
Contributor

📌 Commit 97029f5 has been approved by emilio,jdm

@highfive highfive added S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. and removed S-awaiting-review There is new code that needs to be reviewed. labels Aug 15, 2019
@bors-servo
Copy link
Contributor

⌛ Testing commit 97029f5 with merge c001eb1...

bors-servo pushed a commit that referenced this pull request Aug 15, 2019
style: Sync changes from mozilla-central.

See each individual commit for details.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/23973)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

💔 Test failed - linux-rel-wpt

@highfive highfive added S-tests-failed The changes caused existing tests to fail. and removed S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. labels Aug 15, 2019
This was an oversight in bug 1520154. We kept the -moz- version in the specified
value but not the computed value.

That's a very peculiar way of making aliases work. This makes them work
consistently as many other aliases instead.

Also, add an assert that would've caught this much much earlier.

Differential Revision: https://phabricator.services.mozilla.com/D40063
@highfive highfive added S-awaiting-review There is new code that needs to be reviewed. and removed S-tests-failed The changes caused existing tests to fail. labels Aug 15, 2019
@emilio
Copy link
Member Author

emilio commented Aug 15, 2019

@bors-servo r=emilio,jdm

  • Moar passes

@bors-servo
Copy link
Contributor

📌 Commit d935232 has been approved by emilio,jdm

@highfive highfive added S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. and removed S-awaiting-review There is new code that needs to be reviewed. labels Aug 15, 2019
@bors-servo
Copy link
Contributor

⌛ Testing commit d935232 with merge fbd3a63...

bors-servo pushed a commit that referenced this pull request Aug 15, 2019
style: Sync changes from mozilla-central.

See each individual commit for details.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/23973)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

💔 Test failed - status-taskcluster

@highfive highfive added S-tests-failed The changes caused existing tests to fail. and removed S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. labels Aug 15, 2019
@jdm
Copy link
Member

jdm commented Aug 15, 2019

@bors-servo retry

@emilio
Copy link
Member Author

emilio commented Aug 16, 2019

@bors-servo r-

@emilio
Copy link
Member Author

emilio commented Aug 16, 2019

@bors-servo r=emilio,jdm

@bors-servo
Copy link
Contributor

📌 Commit d935232 has been approved by emilio,jdm

@highfive highfive added S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. and removed S-tests-failed The changes caused existing tests to fail. labels Aug 16, 2019
@bors-servo
Copy link
Contributor

⌛ Testing commit d935232 with merge aa60077...

bors-servo pushed a commit that referenced this pull request Aug 16, 2019
style: Sync changes from mozilla-central.

See each individual commit for details.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/23973)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

☀️ Test successful - linux-rel-css, linux-rel-wpt, status-taskcluster
Approved by: emilio,jdm
Pushing aa60077 to master...

@bors-servo bors-servo merged commit d935232 into servo:master Aug 16, 2019
@highfive highfive removed the S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. label Aug 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

8 participants