Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

matrix-synapse: 1.2.1 -> 1.3.0 #66677

Closed
wants to merge 2 commits into from
Closed

matrix-synapse: 1.2.1 -> 1.3.0 #66677

wants to merge 2 commits into from

Conversation

mguentner
Copy link
Contributor

Motivation for this change

https://github.com/matrix-org/synapse/releases/tag/v1.3.0

Performance improvements mostly. Added sd_notify due to matrix-org/synapse#5732

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @pacien @Ekleog

@mguentner
Copy link
Contributor Author

Off-Topic

I created a channel for the coordination / discussion of the matrix subsystem.
Feel free to join! #matrix-nix:transformierende-gesellschaft.org 🕸️

@ofborg ofborg bot requested a review from Ekleog August 15, 2019 13:38
@peterhoeg
Copy link
Member

How about changing the nixos module as well to make use of this?

@pacien
Copy link
Contributor

pacien commented Aug 15, 2019

@ofborg build nixosTests.matrix-synapse

@mguentner
Copy link
Contributor Author

@peterhoeg

You mean Type=notify in the systemd unit? Is there anything more to do?
I will be able to do in the next days!

@peterhoeg
Copy link
Member

peterhoeg commented Aug 16, 2019 via email

@mguentner
nixos/matrix-synapse: use notify instead of simple
9129da8 
Starting with 1.3.0, matrix-synapse supports notifying
systemd. Relevant PR: matrix-org/synapse#5732
@mguentner
Copy link
Contributor Author

I changed the module as well.
Please keep in mind that config.package now needs to have sd-notify support.

@bachp
Copy link
Member

bachp commented Aug 17, 2019

Seems like v1.3.1 dropped the the sdnotify dependency again. Seems like they implemented the functionality manually.

@mguentner
Copy link
Contributor Author

I will update the branch asap.

@mguentner
Copy link
Contributor Author

replaced by #66814

@mguentner mguentner closed this Aug 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pacien pacien pacien approved these changes

@Ekleog Ekleog Awaiting requested review from Ekleog

Assignees
No one assigned
Labels
6.topic: nixos 8.has: module (update) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@mguentner @peterhoeg @pacien @bachp