Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pythonPackages.typing: 3.6.6 -> 3.7.4 #66678

Closed
wants to merge 1 commit into from
Closed

pythonPackages.typing: 3.6.6 -> 3.7.4 #66678

wants to merge 1 commit into from

Conversation

furrycatherder
Copy link
Contributor

@furrycatherder furrycatherder commented Aug 15, 2019 •
edited

Motivation for this change

Fixes #66660.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

@jonringer
Copy link
Contributor

@GrahamcOfBorg build pythonPackages.typing-extensions

@jonringer
Copy link
Contributor

seeing as this triggers 500+ rebuilds, you may want to make this change against staging which is used to mitigate how much hydra has to rebuild.

@furrycatherder furrycatherder changed the base branch from master to staging August 15, 2019 19:23
@furrycatherder
Copy link
Contributor Author

@jonringer Anything else needed from my end? When does this go from staging to the unstable channel?

@jonringer
Copy link
Contributor

I'm not completely sure, I think @FRidh usually curates the staging branch. But I'm not completely sure. I just know that the automated bot r-ryantm will do his PR's against staging if there's over 100 rebuilds to avoid thrashing compute resources on master.

@FRidh
Copy link
Member

FRidh commented Aug 17, 2019 •
edited

@GrahamcOfBorg build python3Packages.typing python3Packages.mypy

@FRidh
Copy link
Member

FRidh commented Aug 17, 2019

I am surprised to see that typing causes so many rebuilds. But it is a dependency of sphinx nowadays for it to document type hints I suppose. If it builds it can go in staging. Unless it breaks sphinx that is.

@FRidh
Copy link
Member

FRidh commented Aug 17, 2019

@GrahamcOfBorg build python2Packages.sphinx python2Packages.mypy

@FRidh
Copy link
Member

FRidh commented Aug 18, 2019

Thanks. Pushed to staging.

@FRidh FRidh closed this Aug 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FRidh FRidh Awaiting requested review from FRidh

Assignees
No one assigned
Labels
6.topic: python 10.rebuild-darwin: 101-500 10.rebuild-linux: 501-1000 10.rebuild-linux: 501+
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@furrycatherder @jonringer @FRidh