Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

linuxPackages/ixgbevf: 4.3.4 -> 4.6.1, unbreak #66664

Merged
merged 1 commit into from Aug 15, 2019
Merged

linuxPackages/ixgbevf: 4.3.4 -> 4.6.1, unbreak #66664

merged 1 commit into from Aug 15, 2019

Conversation

danbst
Copy link
Contributor

@danbst danbst commented Aug 15, 2019

Motivation for this change

Update. Kernel ships it's own version of ixgbevf driver, so this out-of-tree driver should only be used with extremely old kernels.

I've marked it as broken for newer kernels, both because it is broken and no longer of much use.

Related #58956

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @peterhoeg

@danbst
Copy link
Contributor Author

danbst commented Aug 15, 2019

Related Hydra failures: https://hydra.nixos.org/eval/1536115?filter=ixgbevf&compare=1536056&full=1#tabs-still-fail

@danbst danbst merged commit a8d1920 into NixOS:master Aug 15, 2019
@danbst danbst deleted the update-ixgbevf branch August 15, 2019 11:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 11-100
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@danbst