Bridge CSS comparison functions min/max with CSS typed OM objects #18446
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
approved these changes
Aug 15, 2019
This patch adds two-way conversions between CSS typed OM objects and Blink internal CSSMathFunction objects when comparison functions are involved, so that we can operate on CSS comparison functions with typed OM effectively. Bug: 825895 Change-Id: I883f5691ad6ac564b575f62be4b96a169743715d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1745621 Reviewed-by: Rune Lillesveen <futhark@chromium.org> Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org> Cr-Commit-Position: refs/heads/master@{#687418}
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-1745621
branch
from
a041b60
to
a541f30
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch adds two-way conversions between CSS typed OM objects and
Blink internal CSSMathFunction objects when comparison functions are
involved, so that we can operate on CSS comparison functions with
typed OM effectively.
Bug: 825895
Change-Id: I883f5691ad6ac564b575f62be4b96a169743715d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1745621
Reviewed-by: Rune Lillesveen <futhark@chromium.org>
Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#687418}