New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Azure Pipelines] Enable safaridriver --diagnose
logs
#18444
Conversation
displayName: 'Run tests (Safari Technology Preview)' | ||
- task: PublishBuildArtifacts@1 | ||
displayName: 'Publish results' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I confirmed locally that |
https://dev.azure.com/web-platform-tests/wpt/_build/results?buildId=27221 showed this to work for the infrastructure/ tests. There were 10 log files produced:
The first was the largest of them, and I've pasted it into https://gist.github.com/foolip/5bca5e1504bc9206e0763b114d8e798f. @smfr @youennf @burg can any of you review this and say if it's adding valuable information? Once #18397 has been resolved I can trigger full runs and see if there's something interesting in the logs. |
Full run of the two Safaris in progress to test this: https://dev.azure.com/web-platform-tests/wpt/_build/results?buildId=27258 |
https://dev.azure.com/web-platform-tests/wpt/_build/results?buildId=27258 finished and has the logs as artifacts. safaridriver-logs.zip is over 450 MB, so always collecting these logs might not be a great idea. There are 155 log files, and correlating them to a failed job isn't going to be easy since they're named by process ID and that isn't included in the main logs, right @gsnedders? |
At the end of the log I see: |
@foolip, these logs are pretty much required to investigate any safaridriver failures. That said, I think they are too big to always save, and hard to sort out when you have a handful of them. The --diagnose option is designed to handle situations where safaridriver crashes immediately or in response to New Session command failing. The 'safari:diagnose" capability is more fine-grained and creates log files with the session UUID in it. This may be better for your purposes if you plan to re-run failing tests with additional diagnostics enabled. |
@burg since this will be used for debugging problems, we could set it up so that logs are only collected when @youennf I've invited you and @burg to the Azure Pipelines project in the hope that you'll be able to trigger runs yourselves. I'd also be happy to start runs if you can't make it work. |
I'm going to close this as it hasn't been necessary for debugging. @burg if you think having this for all runs would be valuable, or a way to enable it for select runs, please let me know. |
You'll need the output to file bugs that I can diagnose easily. Can you keep it opt-in?
… On Nov 19, 2019, at 7:36 AM, Philip Jägenstedt ***@***.***> wrote:
I'm going to close this as it hasn't been necessary for debugging. @burg <https://github.com/burg> if you think having this for all runs would be valuable, or a way to enable it for select runs, please let me know.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub <#18444?email_source=notifications&email_token=AAARIGHY6ZDNUKUTJAGPM53QUQBWXA5CNFSM4IL3N7A2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEEOTOLY#issuecomment-555562799>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAARIGEDTJRQIUV6RAXJKCTQUQBWXANCNFSM4IL3N7AQ>.
|
@burg yeah it would be easy enough to keep this configuration in the repo and ready to be triggered. Have you been using the If you'd be willing to make changes to a branch to trigger this, then I could just add a variable that defaults to false that could could set to true in one of the YAML files. |
As long as there are instructions somewhere on how to trigger this, it sounds fine to implement however you want.
-Brian
… On Nov 27, 2019, at 5:08 AM, Philip Jägenstedt ***@***.***> wrote:
@burg <https://github.com/burg> yeah it would be easy enough to keep this configuration in the repo and ready to be triggered. Have you been using the triggers/safari_preview branch before, or triggering runs from the Azure Pipelines console? Depending on how you do it I'd need to put the control knob in a different place.
If you'd be willing to make changes to a branch to trigger this, then I could just add a variable that defaults to false that could could set to true in one of the YAML files.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub <#18444?email_source=notifications&email_token=AAARIGD4P5ZFQDFAGV3BIHTQVZWLPA5CNFSM4IL3N7A2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEFJOFBA#issuecomment-559080068>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAARIGEGJ6IGTDJQUE7SIFTQVZWLPANCNFSM4IL3N7AQ>.
|
I've done this in #21367 now. |
For #16229.