Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update to harfbuzz 2.6.0. #161

Closed
wants to merge 2 commits into from
Closed

Update to harfbuzz 2.6.0. #161

wants to merge 2 commits into from

Conversation

waywardmonkeys
Copy link
Collaborator

@waywardmonkeys waywardmonkeys commented Aug 15, 2019 •
edited by larsbergstrom

This change is Reviewable

@jdm
Copy link
Member

jdm commented Aug 15, 2019

The macOS shared library CI configuration is reporting errors but not the static library configuration for some reason:

cargo:warning=/Users/travis/build/servo/rust-harfbuzz/target/debug/build/harfbuzz-sys-test-e44a89623ef40388/out/all.c:7516:26: error: unknown type name 'hb_ot_layout_baseline_tag_t'

cargo:warning=            static const hb_ot_layout_baseline_tag_t __test_const_HB_OT_LAYOUT_BASELINE_TAG_ROMAN_val = HB_OT_LAYOUT_BASELINE_TAG_ROMAN;

cargo:warning=                         ^

cargo:warning=/Users/travis/build/servo/rust-harfbuzz/target/debug/build/harfbuzz-sys-test-e44a89623ef40388/out/all.c:7516:105: error: use of undeclared identifier 'HB_OT_LAYOUT_BASELINE_TAG_ROMAN'

cargo:warning=            static const hb_ot_layout_baseline_tag_t __test_const_HB_OT_LAYOUT_BASELINE_TAG_ROMAN_val = HB_OT_LAYOUT_BASELINE_TAG_ROMAN;

cargo:warning=                                                                                                        ^

cargo:warning=/Users/travis/build/servo/rust-harfbuzz/target/debug/build/harfbuzz-sys-test-e44a89623ef40388/out/all.c:7517:20: error: unknown type name 'hb_ot_layout_baseline_tag_t'

cargo:warning=             const hb_ot_layout_baseline_tag_t* __test_const_HB_OT_LAYOUT_BASELINE_TAG_ROMAN(void) {

cargo:warning=                   ^

cargo:warning=/Users/travis/build/servo/rust-harfbuzz/target/debug/build/harfbuzz-sys-test-e44a89623ef40388/out/all.c:7522:26: error: unknown type name 'hb_ot_layout_baseline_tag_t'

cargo:warning=            static const hb_ot_layout_baseline_tag_t __test_const_HB_OT_LAYOUT_BASELINE_TAG_HANGING_val = HB_OT_LAYOUT_BASELINE_TAG_HANGING;

cargo:warning=                         ^

cargo:warning=/Users/travis/build/servo/rust-harfbuzz/target/debug/build/harfbuzz-sys-test-e44a89623ef40388/out/all.c:7522:107: error: use of undeclared identifier 'HB_OT_LAYOUT_BASELINE_TAG_HANGING'

cargo:warning=            static const hb_ot_layout_baseline_tag_t __test_const_HB_OT_LAYOUT_BASELINE_TAG_HANGING_val = HB_OT_LAYOUT_BASELINE_TAG_HANGING;

cargo:warning=                                                                                                          ^

cargo:warning=/Users/travis/build/servo/rust-harfbuzz/target/debug/build/harfbuzz-sys-test-e44a89623ef40388/out/all.c:7523:20: error: unknown type name 'hb_ot_layout_baseline_tag_t'

cargo:warning=             const hb_ot_layout_baseline_tag_t* __test_const_HB_OT_LAYOUT_BASELINE_TAG_HANGING(void) {

cargo:warning=                   ^

cargo:warning=/Users/travis/build/servo/rust-harfbuzz/target/debug/build/harfbuzz-sys-test-e44a89623ef40388/out/all.c:7528:26: error: unknown type name 'hb_ot_layout_baseline_tag_t'

cargo:warning=            static const hb_ot_layout_baseline_tag_t __test_const_HB_OT_LAYOUT_BASELINE_TAG_IDEO_FACE_BOTTOM_OR_LEFT_val = HB_OT_LAYOUT_BASELINE_TAG_IDEO_FACE_BOTTOM_OR_LEFT;

cargo:warning=                         ^

cargo:warning=/Users/travis/build/servo/rust-harfbuzz/target/debug/build/harfbuzz-sys-test-e44a89623ef40388/out/all.c:7528:124: error: use of undeclared identifier 'HB_OT_LAYOUT_BASELINE_TAG_IDEO_FACE_BOTTOM_OR_LEFT'

cargo:warning=            static const hb_ot_layout_baseline_tag_t __test_const_HB_OT_LAYOUT_BASELINE_TAG_IDEO_FACE_BOTTOM_OR_LEFT_val = HB_OT_LAYOUT_BASELINE_TAG_IDEO_FACE_BOTTOM_OR_LEFT;

cargo:warning=                                                                                                                           ^

cargo:warning=/Users/travis/build/servo/rust-harfbuzz/target/debug/build/harfbuzz-sys-test-e44a89623ef40388/out/all.c:7529:20: error: unknown type name 'hb_ot_layout_baseline_tag_t'

cargo:warning=             const hb_ot_layout_baseline_tag_t* __test_const_HB_OT_LAYOUT_BASELINE_TAG_IDEO_FACE_BOTTOM_OR_LEFT(void) {

cargo:warning=                   ^

cargo:warning=/Users/travis/build/servo/rust-harfbuzz/target/debug/build/harfbuzz-sys-test-e44a89623ef40388/out/all.c:7534:26: error: unknown type name 'hb_ot_layout_baseline_tag_t'

cargo:warning=            static const hb_ot_layout_baseline_tag_t __test_const_HB_OT_LAYOUT_BASELINE_TAG_IDEO_FACE_TOP_OR_RIGHT_val = HB_OT_LAYOUT_BASELINE_TAG_IDEO_FACE_TOP_OR_RIGHT;

cargo:warning=                         ^

cargo:warning=/Users/travis/build/servo/rust-harfbuzz/target/debug/build/harfbuzz-sys-test-e44a89623ef40388/out/all.c:7534:122: error: use of undeclared identifier 'HB_OT_LAYOUT_BASELINE_TAG_IDEO_FACE_TOP_OR_RIGHT'

cargo:warning=            static const hb_ot_layout_baseline_tag_t __test_const_HB_OT_LAYOUT_BASELINE_TAG_IDEO_FACE_TOP_OR_RIGHT_val = HB_OT_LAYOUT_BASELINE_TAG_IDEO_FACE_TOP_OR_RIGHT;

cargo:warning=                                                                                                                         ^

cargo:warning=/Users/travis/build/servo/rust-harfbuzz/target/debug/build/harfbuzz-sys-test-e44a89623ef40388/out/all.c:7535:20: error: unknown type name 'hb_ot_layout_baseline_tag_t'

cargo:warning=             const hb_ot_layout_baseline_tag_t* __test_const_HB_OT_LAYOUT_BASELINE_TAG_IDEO_FACE_TOP_OR_RIGHT(void) {

cargo:warning=                   ^

cargo:warning=/Users/travis/build/servo/rust-harfbuzz/target/debug/build/harfbuzz-sys-test-e44a89623ef40388/out/all.c:7540:26: error: unknown type name 'hb_ot_layout_baseline_tag_t'

cargo:warning=            static const hb_ot_layout_baseline_tag_t __test_const_HB_OT_LAYOUT_BASELINE_TAG_IDEO_EMBOX_BOTTOM_OR_LEFT_val = HB_OT_LAYOUT_BASELINE_TAG_IDEO_EMBOX_BOTTOM_OR_LEFT;

cargo:warning=                         ^

cargo:warning=/Users/travis/build/servo/rust-harfbuzz/target/debug/build/harfbuzz-sys-test-e44a89623ef40388/out/all.c:7540:125: error: use of undeclared identifier 'HB_OT_LAYOUT_BASELINE_TAG_IDEO_EMBOX_BOTTOM_OR_LEFT'

cargo:warning=            static const hb_ot_layout_baseline_tag_t __test_const_HB_OT_LAYOUT_BASELINE_TAG_IDEO_EMBOX_BOTTOM_OR_LEFT_val = HB_OT_LAYOUT_BASELINE_TAG_IDEO_EMBOX_BOTTOM_OR_LEFT;

cargo:warning=                                                                                                                            ^

cargo:warning=/Users/travis/build/servo/rust-harfbuzz/target/debug/build/harfbuzz-sys-test-e44a89623ef40388/out/all.c:7541:20: error: unknown type name 'hb_ot_layout_baseline_tag_t'

cargo:warning=             const hb_ot_layout_baseline_tag_t* __test_const_HB_OT_LAYOUT_BASELINE_TAG_IDEO_EMBOX_BOTTOM_OR_LEFT(void) {

cargo:warning=                   ^

cargo:warning=/Users/travis/build/servo/rust-harfbuzz/target/debug/build/harfbuzz-sys-test-e44a89623ef40388/out/all.c:7546:26: error: unknown type name 'hb_ot_layout_baseline_tag_t'

cargo:warning=            static const hb_ot_layout_baseline_tag_t __test_const_HB_OT_LAYOUT_BASELINE_TAG_IDEO_EMBOX_TOP_OR_RIGHT_val = HB_OT_LAYOUT_BASELINE_TAG_IDEO_EMBOX_TOP_OR_RIGHT;

cargo:warning=                         ^

cargo:warning=/Users/travis/build/servo/rust-harfbuzz/target/debug/build/harfbuzz-sys-test-e44a89623ef40388/out/all.c:7546:123: error: use of undeclared identifier 'HB_OT_LAYOUT_BASELINE_TAG_IDEO_EMBOX_TOP_OR_RIGHT'

cargo:warning=            static const hb_ot_layout_baseline_tag_t __test_const_HB_OT_LAYOUT_BASELINE_TAG_IDEO_EMBOX_TOP_OR_RIGHT_val = HB_OT_LAYOUT_BASELINE_TAG_IDEO_EMBOX_TOP_OR_RIGHT;

cargo:warning=                                                                                                                          ^

cargo:warning=/Users/travis/build/servo/rust-harfbuzz/target/debug/build/harfbuzz-sys-test-e44a89623ef40388/out/all.c:7547:20: error: unknown type name 'hb_ot_layout_baseline_tag_t'

cargo:warning=             const hb_ot_layout_baseline_tag_t* __test_const_HB_OT_LAYOUT_BASELINE_TAG_IDEO_EMBOX_TOP_OR_RIGHT(void) {

cargo:warning=                   ^

cargo:warning=/Users/travis/build/servo/rust-harfbuzz/target/debug/build/harfbuzz-sys-test-e44a89623ef40388/out/all.c:7552:26: error: unknown type name 'hb_ot_layout_baseline_tag_t'

cargo:warning=            static const hb_ot_layout_baseline_tag_t __test_const_HB_OT_LAYOUT_BASELINE_TAG_MATH_val = HB_OT_LAYOUT_BASELINE_TAG_MATH;

cargo:warning=                         ^

cargo:warning=fatal error: too many errors emitted, stopping now [-ferror-limit=]

cargo:warning=20 errors generated.

exit code: 1

--- stderr

rust version: 1.37.0

@waywardmonkeys
Copy link
Collaborator Author

The shared build is trying to build against harfbuzz 2.4 from homebrew (which is odd, since my homebrew says it has 2.5.3). It is true that homebrew doesn't have 2.6.0 yet, and so that is at least part of this failure.

@jdm
Copy link
Member

jdm commented Aug 15, 2019

You could try adding brew update to the travis CI steps, since the docs say "The Homebrew addon uses the Homebrew database on the build image by default, but can be configured to run brew update if needed."

@waywardmonkeys
Copy link
Collaborator Author

I'm trying a different approach here. If this works, then I'll do a new PR with that by itself, and then a new PR for updating to Harfbuzz 1.6.1 instead.

@waywardmonkeys
Use embedded Harfbuzz for ctest on macOS TravisCI.
d45b993 
This removes the need to have an up-to-date Homebrew.
@waywardmonkeys waywardmonkeys deleted the update-to-harfbuzz-2.6.0 branch September 19, 2019 06:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@waywardmonkeys @jdm