Fix :enabled so that it does not match links #18460
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
approved these changes
Aug 15, 2019
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-1754509
branch
from
cf3871a
to
32d4a48
Compare
chromium-wpt-export-bot
changed the title
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-1754509
branch
from
32d4a48
to
3b2d5e2
Compare
The spec [1] is clear that :enabled and :disabled should *not* match link elements. Prior to this CL, links would match :enabled in Chrome, but would never match :disabled. This is obviously contrary to the spec, and it also does not match other browsers' behavior: Firefox (68), Safari (12.1), Edge (18) and IE (11) all work according to the spec. Now, neither :enabled nor :disabled match links in Chrome. [1] https://html.spec.whatwg.org/multipage/semantics-other.html#selector-enabled Bug: 993387 Change-Id: I745a314fdac720243ebf37eed4fdcf57228cc3cc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1754509 Commit-Queue: Mason Freed <masonfreed@chromium.org> Reviewed-by: Rune Lillesveen <futhark@chromium.org> Cr-Commit-Position: refs/heads/master@{#688241}
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-1754509
branch
from
3b2d5e2
to
a856e08
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The spec [1] is clear that :enabled and :disabled should not match
link elements. Prior to this CL, links would match :enabled in Chrome,
but would never match :disabled. This is obviously contrary to the
spec, and it also does not match other browsers' behavior:
Firefox (68), Safari (12.1), Edge (18) and IE (11) all work according
to the spec.
Now, neither :enabled nor :disabled match links in Chrome.
[1] https://html.spec.whatwg.org/multipage/semantics-other.html#selector-enabled
Bug: 993387
Change-Id: I745a314fdac720243ebf37eed4fdcf57228cc3cc
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1754509
Commit-Queue: Mason Freed <masonfreed@chromium.org>
Reviewed-by: Rune Lillesveen <futhark@chromium.org>
Cr-Commit-Position: refs/heads/master@{#688241}