Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

xmrig: 2.14.4 -> 3.0.0 #66757

Merged
merged 2 commits into from Aug 18, 2019
Merged

xmrig: 2.14.4 -> 3.0.0 #66757

merged 2 commits into from Aug 18, 2019

Conversation

kim0
Copy link
Contributor

@kim0 kim0 commented Aug 17, 2019

Motivation for this change

Upgrade xmrig 2.14.4 -> 3.0.0

Things done

added hwloc dependency, and bumped version

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @fpletz

@ofborg ofborg bot requested a review from fpletz August 17, 2019 15:13
@mmahut
Copy link
Member

mmahut commented Aug 17, 2019

@GrahamcOfBorg build xmrig

@kim0
Copy link
Contributor Author

kim0 commented Aug 18, 2019

@mmahut .. Morning, is it acceptable now ? Thanks

@mmahut
Copy link
Member

mmahut commented Aug 18, 2019

@GrahamcOfBorg build xmrig

@mmahut mmahut merged commit bcc14b2 into NixOS:master Aug 18, 2019
@kim0 kim0 deleted the xmrig300 branch August 18, 2019 14:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mmahut mmahut mmahut left review comments

@fpletz fpletz Awaiting requested review from fpletz

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@kim0 @mmahut