Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bazel: cctools runtime dependency on darwin #66724

Merged
merged 1 commit into from Aug 31, 2019
Merged

bazel: cctools runtime dependency on darwin #66724

merged 1 commit into from Aug 31, 2019

Conversation

aherrmann
Copy link
Member

Denote runtime dependeny on cctools on darwin.

Motivation for this change

The bazel build patches paths like /usr/bin/install_name_tool to refer
to ${cctools}/bin/install_name_tool instead. If the corresponding
runtime dependency is not denoted, then darwin users can encounter "file
not found" errors, e.g. when they fetch bazel from a binary cache and
don't have cctools in their own nix store.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @Profpatsch

@aherrmann
bazel: cctools runtime dependency on darwin
b9d1795 
The bazel build patches paths like `/usr/bin/install_name_tool` to refer
to `${cctools}/bin/install_name_tool` instead. If the corresponding
runtime dependency is not denoted, then darwin users can encounter "file
not found" errors, e.g. when they fetch bazel from a binary cache and
don't have `cctools` in their own nix store.
@ofborg ofborg bot added 6.topic: darwin Running or building packages on Darwin 10.rebuild-darwin: 1-10 10.rebuild-linux: 0 labels Aug 16, 2019
@mmahut
Copy link
Member

mmahut commented Aug 19, 2019

@GrahamcOfBorg build bazel

@kalbasit
Copy link
Member

kalbasit commented Aug 25, 2019 •
edited

@GrahamcOfBorg build bazel bazel.tests

cc @Profpatsch @guibou

@kalbasit kalbasit merged commit 1bf70fd into NixOS:master Aug 31, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kalbasit kalbasit kalbasit approved these changes

@Profpatsch Profpatsch Awaiting requested review from Profpatsch Profpatsch is a code owner

Assignees
No one assigned
Labels
6.topic: darwin Running or building packages on Darwin 10.rebuild-darwin: 1-10 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@aherrmann @mmahut @kalbasit