Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

trezord: adding emulator support (plus test) #66722

Merged
merged 2 commits into from Aug 22, 2019

Conversation

mmahut
Copy link
Member

@mmahut mmahut commented Aug 16, 2019

Motivation for this change

Adding support for emulator feature in the trezord service. Also
adding a test for it.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

@mmahut
Copy link
Member Author

mmahut commented Aug 16, 2019

@GrahamcOfBorg test trezord

@mmahut mmahut changed the title trezord: adding emultor support (plus test) trezord: adding emulator support (plus test) Aug 16, 2019
@mmahut mmahut merged commit f4ca6e3 into NixOS:master Aug 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants