[ChromeDriver] Creates new ChromeDriver SetPermission command #18429
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
approved these changes
Aug 14, 2019
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-1666438
branch
9 times, most recently
from
ffb147b
to
96a1b46
Compare
Adds W3C WebDriver extension, SetPermission, to support simple permissions. Design doc: go/chromedriver-permissions-ext of the spec, the tests do not test much, so new tests were added to run_py_tests to enfore certain behaviors. Tested: Passing W3C permissions tests. Due to the relaxed definition Bug: chromedriver:2212 Change-Id: Ie61cc4c0e18c714f93ac7ab918d0cec0e4210e1e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1666438 Reviewed-by: Balazs Engedy <engedy@chromium.org> Reviewed-by: Robert Ma <robertma@chromium.org> Reviewed-by: Avi Drissman <avi@chromium.org> Reviewed-by: Caleb Rouleau <crouleau@chromium.org> Reviewed-by: John Chen <johnchen@chromium.org> Commit-Queue: Rohan Pavone <rohpavone@chromium.org> Cr-Commit-Position: refs/heads/master@{#690496}
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-1666438
branch
from
96a1b46
to
ca26bfa
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds W3C WebDriver extension, SetPermission, to support simple
permissions.
Design doc: go/chromedriver-permissions-ext
of the spec, the tests do not test much, so new tests were added to
run_py_tests to enfore certain behaviors.
Tested: Passing W3C permissions tests. Due to the relaxed definition
Bug: chromedriver:2212
Change-Id: Ie61cc4c0e18c714f93ac7ab918d0cec0e4210e1e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1666438
Reviewed-by: Balazs Engedy <engedy@chromium.org>
Reviewed-by: Robert Ma <robertma@chromium.org>
Reviewed-by: Avi Drissman <avi@chromium.org>
Reviewed-by: Caleb Rouleau <crouleau@chromium.org>
Reviewed-by: John Chen <johnchen@chromium.org>
Commit-Queue: Rohan Pavone <rohpavone@chromium.org>
Cr-Commit-Position: refs/heads/master@{#690496}