Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable testdriver to return results to tests. #18431

Merged

Conversation

LukeZielinski
Copy link
Contributor

This resolves issue #10716, and is recreated from an earlier PR #11080.

The immediate use case for this is to support testing of WebAuthN, specifically a getCredentials function that can be used to inspect keys installed on a device. More info on this in the testing API doc and proposed spec change.

@wpt-pr-bot wpt-pr-bot added infra wptrunner The automated test runner, commonly called through ./wpt run labels Aug 14, 2019
@LukeZielinski
Copy link
Contributor Author

LukeZielinski commented Aug 14, 2019

@gsnedders since you were involved in #11080

I think the only remaining AI from that old PR is the question about testing. Longer term when the getCredentials API exists we can have an infra test for that which should cover this feature.

Right now, I just hacked an existing API to return stuff and it behaves as expected locally: #18432

@LukeZielinski
Copy link
Contributor Author

@nsatragno FYI1

@LukeZielinski LukeZielinski merged commit 5fc1b5c into web-platform-tests:master Aug 19, 2019
@LukeZielinski LukeZielinski deleted the testdriver-returns branch August 19, 2019 16:53
natechapin pushed a commit to natechapin/wpt that referenced this pull request Aug 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs infra wptrunner The automated test runner, commonly called through ./wpt run
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants