Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create a libhlservo library #23974

Closed
jdm opened this issue Aug 15, 2019 · 1 comment
Closed

Create a libhlservo library #23974

jdm opened this issue Aug 15, 2019 · 1 comment

Comments

@jdm
Copy link
Member

jdm commented Aug 15, 2019

There is a bunch of Hololens-specific embedding that's ending up in per-platform cfg blocks in libsimpleservo's C API crate. We should create a new Rust crate that contains the Rust-specific embedding pieces (such as stdio/stdout redirection, logging setup, and GST_LOG redirection) and reexports all of the important bits of the C API.

@paulrouget
Copy link
Contributor

I'm not convinced we have to create a hl specific library.

I'm not sure it's all Hololens specific. Isn't it Windows specific? Maybe it makes sense to keep these things under simpleservo/capi/? As in, if someone wants to use servo in their app on windows, they will need logs and redirection as well.

And if there's something HL specific, could it be moved in support/hololens?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants