Create new list for paced animation values #18491
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
approved these changes
Aug 16, 2019
chromium-wpt-export-bot
changed the title
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-1757825
branch
3 times, most recently
from
3a52956
to
37aed89
Compare
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-1757825
branch
from
37aed89
to
a896ce0
Compare
SVGAnimationElement::calculateKeyTimesForCalcModePaced() used to overwrite the data passed in by the user. This commit fixes the issue and there are now two lists stored, one with the user data and one with the key times for paced. This is a bug fix and should only affect SVGAnimationElements, there will be an increase in memory usage, especially for animation intensive scenes. Can be avoided by changing to a CPU heavy approach, but this will probably be more energy efficient for mobile devices. Bug: 231525 Change-Id: Ief9bbb8c6d1133d0041ad2c8f5a3d63f9ddcde90 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1757825 Reviewed-by: Fredrik Söderquist <fs@opera.com> Commit-Queue: Edvard Thörnros <edvardt@opera.com> Cr-Commit-Position: refs/heads/master@{#687651}
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-1757825
branch
from
a896ce0
to
4c0d199
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SVGAnimationElement::calculateKeyTimesForCalcModePaced() used to
overwrite the data passed in by the user. This commit fixes the
issue and there are now two lists stored, one with the user data
and one with the key times for paced.
This is a bug fix and should only affect SVGAnimationElements,
there will be an increase in memory usage, especially for animation
intensive scenes. Can be avoided by changing to a CPU heavy approach,
but this will probably be more energy efficient for mobile devices.
Bug: 231525
Change-Id: Ief9bbb8c6d1133d0041ad2c8f5a3d63f9ddcde90
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1757825
Reviewed-by: Fredrik Söderquist <fs@opera.com>
Commit-Queue: Edvard Thörnros <edvardt@opera.com>
Cr-Commit-Position: refs/heads/master@{#687651}