Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tusk: init at v0.23.0 #66710

Merged
merged 1 commit into from Jan 8, 2020
Merged

tusk: init at v0.23.0 #66710

merged 1 commit into from Jan 8, 2020

Conversation

tbenst
Copy link
Contributor

@tbenst tbenst commented Aug 16, 2019

Motivation for this change

add Tusk AppImage package.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@tbenst
Copy link
Contributor Author

tbenst commented Aug 16, 2019

would help if I added the files :D. Should be good to go now

@tbenst
Copy link
Contributor Author

tbenst commented Aug 18, 2019

@mmahut thx for review, all requested changes made

Copy link
Member

@aanderse aanderse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tbenst 2 minor changes, if you don't mind. I haven't worked with appimage on nixos yet, but this looks relatively straight forward. 👍

pkgs/applications/office/tusk/default.nix Outdated Show resolved Hide resolved
pkgs/applications/office/tusk/default.nix Outdated Show resolved Hide resolved
@tbenst
Copy link
Contributor Author

tbenst commented Aug 31, 2019

@aanderse thx! changes made.

Do you happen to know how to add app name / icon to the lauancher? Fully functional but requires typing "tusk" at cmd line vs using eg KDE launcher

pkgs/applications/office/tusk/default.nix Outdated Show resolved Hide resolved
pkgs/applications/office/tusk/default.nix Show resolved Hide resolved
@aanderse
Copy link
Member

Do you happen to know how to add app name / icon to the lauancher? Fully functional but requires typing "tusk" at cmd line vs using eg KDE launcher

This looks like a reasonable example to work from.

@tbenst
Copy link
Contributor Author

tbenst commented Sep 4, 2019

Thanks! I'll give this a look next week or so, away from my NixOS box and on too poor an internet connection right now to test GUI stuff

@tbenst
Copy link
Contributor Author

tbenst commented Dec 12, 2019

@aanderse thanks for tip, worked beautifully. Ready for final review

@aanderse
Copy link
Member

Thanks @tbenst! Did anyone (@mmahut, me?) test this yet?

@tbenst
Copy link
Contributor Author

tbenst commented Jan 7, 2020

@aanderse I've been using it for a couple weeks with no issues!

@tbenst
Copy link
Contributor Author

tbenst commented Jan 8, 2020

@aanderse fixed the trailing 'i'--a vim insert ;)

@aanderse
Copy link
Member

aanderse commented Jan 8, 2020

Sorry this took forever. Thanks for contributing the package! 🎉

@aanderse aanderse merged commit 24967c1 into NixOS:master Jan 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants