Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

drawio: 11.1.1 -> 11.1.4 #66709

Merged
merged 1 commit into from Aug 16, 2019
Merged

drawio: 11.1.1 -> 11.1.4 #66709

merged 1 commit into from Aug 16, 2019

Conversation

danieldk
Copy link
Contributor

Motivation for this change

Changelog:

https://github.com/jgraph/drawio-desktop/releases/tag/v11.1.4

The most important user-visible change is that the binary is renamed
from draw.io to drawio.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

@danieldk
drawio: 11.1.1 -> 11.1.4
cbfdb79 
Changelog:

https://github.com/jgraph/drawio-desktop/releases/tag/v11.1.4

The most important user-visible change is that the binary is renamed
from draw.io to drawio.
@danieldk
Copy link
Contributor Author

@GrahamcOfBorg build drawio

WilliButz
WilliButz approved these changes Aug 16, 2019
View reviewed changes
Copy link
Member

@WilliButz WilliButz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested successfully 👍

@WilliButz WilliButz merged commit feb0694 into NixOS:master Aug 16, 2019
@danieldk danieldk deleted the drawio-11.1.4 branch August 17, 2019 18:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@WilliButz WilliButz WilliButz approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@danieldk @WilliButz