Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

palemoon: 28.6.0.1 -> 28.7.0, drop hardeningDisable #66669

Merged
merged 2 commits into from Sep 6, 2019
Merged

palemoon: 28.6.0.1 -> 28.7.0, drop hardeningDisable #66669

merged 2 commits into from Sep 6, 2019

Conversation

OPNA2608
Copy link
Contributor

@OPNA2608 OPNA2608 commented Aug 15, 2019 •
edited

Tested without the disabled format hardening, it built fine.
Opening about:buildconfig on the Ubuntu build lists -Wformat under the used
compiler flags, so it should be okay anyway.

Motivation for this change

Package update & abit more cleanup work.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested a review from AndersonTorres August 15, 2019 08:51
@mmahut
Copy link
Member

mmahut commented Aug 15, 2019

@GrahamcOfBorg build palemoon

@mmahut
Copy link
Member

mmahut commented Aug 23, 2019

I'm getting the following build error.

builder for '/nix/store/zwbi8p1ixd8xw653m8dr6zq2zmyw8wi0-palemoon-28.6.1.drv' failed with exit code 2; last 10 log lines:
   7:42.97              ^
   7:47.44 libgfx_layers.a.desc
   7:53.01 make[4]: *** [/build/source/config/recurse.mk:71: layout/base/target] Error 2
   7:59.98 make[4]: *** [/build/source/config/recurse.mk:71: dom/bindings/target] Error 2
   7:59.99 make[3]: *** [/build/source/config/recurse.mk:33: compile] Error 2
   8:00.01 make[2]: *** [/build/source/config/rules.mk:494: default] Error 2
   8:00.01 make[1]: *** [/build/source/client.mk:414: realbuild] Error 2
   8:00.01 make: *** [client.mk:170: build] Error 2
   8:00.08 63 compiler warnings present.
   8:00.22 Notification center failed: Install the python dbus module to get a notification when the build finishes.
cannot build derivation '/nix/store/m4klrfw44kblz9ikjcjfm16v4y0ci6zy-env.drv': 1 dependencies couldn't be built

@OPNA2608
Copy link
Contributor Author

OPNA2608 commented Aug 23, 2019 •
edited

I can't reproduce your error, nix-build succeeds in my VM. 🙁
Screenshot_NixOS_19 03_2019-08-23_13:41:33

Can you give more details or the full build log? Here's mine, with the changes of this PR applied onto f096e5a. Should hopefully not have an effect on the result of nix-build on a local git clone, but here's the VM's system information as well just in case.

  • system: "x86_64-linux"
  • host os: Linux 5.1.16, NixOS, 19.03.173068.9ec7625cee5 (Koi)
  • multi-user?: yes
  • sandbox: yes
  • version: nix-env (Nix) 2.2.2
  • channels(root): "nixos-19.03.173068.9ec7625cee5"
  • nixpkgs: /nix/var/nix/profiles/per-user/root/channels/nixos

aanderse
aanderse approved these changes Aug 31, 2019
View reviewed changes
Copy link
Member

@aanderse aanderse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This package also built (eventually...) and ran for me. Would be nice to have one more person confirm this builds for them, or someone to look at what went wrong with the build @mmahut 🤔

@OPNA2608
Copy link
Contributor Author

Upstream tagged a new release 28.7.0 afew days ago, I'll update this PR to the new version as needed and test it once they put up the release notes on Github.

https://github.com/MoonchildProductions/UXP/releases/tag/PM28.7.0_Release

@OPNA2608
Copy link
Contributor Author

OPNA2608 commented Sep 2, 2019

Updated to 28.7.0. (Releae notes)

Tested compiling it, which succeeded after ~30min on 3 threads, and starting it, which appeared to work fine. I can do more thorough testing later today.

@OPNA2608 OPNA2608 changed the title palemoon: 28.6.0.1 -> 28.6.1, drop hardeningDisable palemoon: 28.6.0.1 -> 28.7.0, drop hardeningDisable Sep 2, 2019
@aanderse
Copy link
Member

aanderse commented Sep 2, 2019

New version compiled (eventually) and ran as expected.

@OPNA2608 please squash commits.

@ofborg ofborg bot requested a review from rnhmjoj September 2, 2019 18:29
@aanderse aanderse requested a review from mmahut September 3, 2019 16:24
@rnhmjoj
Copy link
Contributor

rnhmjoj commented Sep 4, 2019

@OPNA2608 Could you please remove my name from the maintainers of this package? I haven't been using pale moon or updating the package for a while.

@rnhmjoj
Copy link
Contributor

rnhmjoj commented Sep 4, 2019

Thank you.

@aanderse aanderse merged commit 22fb70a into NixOS:master Sep 6, 2019
@OPNA2608 OPNA2608 mentioned this pull request Sep 21, 2019
Closed
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aanderse aanderse aanderse approved these changes

@AndersonTorres AndersonTorres Awaiting requested review from AndersonTorres

@rnhmjoj rnhmjoj Awaiting requested review from rnhmjoj

@mmahut mmahut Awaiting requested review from mmahut

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@OPNA2608 @mmahut @aanderse @rnhmjoj