[webnfc] Replace NDEFRecordData#data() with multiple getters #18449
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
approved these changes
Aug 15, 2019
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-1755642
branch
2 times, most recently
from
f260bd8
to
5eaf9cc
Compare
The spec change was introduced at w3c/web-nfc#243. BUG=520391 TBR=dcheng for just adding a TODO into third_party/blink/renderer/modules/nfc/nfc_type_converters.h Change-Id: Iee1841352417065cdf13b08a82ac79cfd6cdb7a5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1755642 Commit-Queue: Leon Han <leon.han@intel.com> Reviewed-by: Reilly Grant <reillyg@chromium.org> Reviewed-by: Rijubrata Bhaumik <rijubrata.bhaumik@intel.com> Cr-Commit-Position: refs/heads/master@{#688007}
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-1755642
branch
from
5eaf9cc
to
2b79496
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The spec change was introduced at
w3c/web-nfc#243.
BUG=520391
TBR=dcheng
for just adding a TODO into
third_party/blink/renderer/modules/nfc/nfc_type_converters.h
Change-Id: Iee1841352417065cdf13b08a82ac79cfd6cdb7a5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1755642
Commit-Queue: Leon Han <leon.han@intel.com>
Reviewed-by: Reilly Grant <reillyg@chromium.org>
Reviewed-by: Rijubrata Bhaumik <rijubrata.bhaumik@intel.com>
Cr-Commit-Position: refs/heads/master@{#688007}