Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

mkvtoolnix: use wrapQtApp #66684

Merged
merged 1 commit into from Aug 18, 2019
Merged

mkvtoolnix: use wrapQtApp #66684

merged 1 commit into from Aug 18, 2019

Conversation

vbgl
Copy link
Contributor

@vbgl vbgl commented Aug 15, 2019

See #65399

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested a review from Fuuzetsu August 15, 2019 15:45
jonringer
jonringer reviewed Aug 15, 2019
View reviewed changes
pkgs/applications/video/mkvtoolnix/default.nix
@@ -4,6 +4,7 @@
, withGUI ? true
, qtbase ? null
, qtmultimedia ? null
, wrapQtAppsHook ? null
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

even though it's supposed to be denote it's optional, weird to see extra whitespace.

Personal preference. Don't feel strongly about it.

Suggested change
, wrapQtAppsHook ? null
, wrapQtAppsHook ? null

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I’ve just followed the style of the two lines above.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

either way, I don't have much of a preference. Just a slight preference :)

pkgs/applications/video/mkvtoolnix/default.nix Outdated Show resolved Hide resolved
jonringer
jonringer approved these changes Aug 15, 2019
View reviewed changes
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nix-review passes on NixOS
diff LGTM
binaries seem to all work
leaf package

@teto
Copy link
Member

teto commented Aug 16, 2019

@GrahamcOfBorg build mkvtoolnix

worldofpeace
worldofpeace approved these changes Aug 18, 2019
View reviewed changes
Copy link
Contributor

@worldofpeace worldofpeace left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've reproduce the issue on master, upon building the package I ensured the correct binary was wrapped.

Executes without an error at runtime ✔️

@worldofpeace worldofpeace merged commit 27dbf75 into NixOS:master Aug 18, 2019
@vbgl vbgl deleted the mkvtoolnix-qt-mkDerivation branch August 19, 2019 05:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonringer jonringer jonringer approved these changes

@worldofpeace worldofpeace worldofpeace approved these changes

@Fuuzetsu Fuuzetsu Awaiting requested review from Fuuzetsu

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@vbgl @teto @jonringer @worldofpeace