Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

codimd: 1.4.0 -> 1.5.0 #66711

Merged
merged 1 commit into from Aug 20, 2019
Merged

codimd: 1.4.0 -> 1.5.0 #66711

merged 1 commit into from Aug 20, 2019

Conversation

WilliButz
Copy link
Member

Motivation for this change

New release

Things done

Successfully tested everything under /features.

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS (x86_64-linux & aarch64-linux)
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@WilliButz WilliButz requested a review from Ma27 August 16, 2019 09:31
@WilliButz
Copy link
Member Author

@GrahamcOfBorg test codimd

@Ma27
Copy link
Member

Ma27 commented Aug 16, 2019

The change itself seems fine (especially happy about getting rid of phantomjs), however I can't give explicit approval as I have a pretty poor uplink (vacation, heh ^^) and can't test it (since I'm not that interested in downloading half the internet today).

Feel free to merge, if you want me to test it, you'd have to wait until tuesday evening :)

Ma27
Ma27 approved these changes Aug 20, 2019
View reviewed changes
Copy link
Member

@Ma27 Ma27 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As already mentioned, the diff looks fine to me. Just built and tested locally, also created a simple NixOS container by running sudo nixos-container create snens --nixos-path `pwd`/nixos --config-file container.nix --local-address 10.242.1.2 --host-address 10.242.1.1 with the following config to test CodiMD 1.5 in the browser:

{
  services.codimd = {
    enable = true;
    configuration.dbURL = "sqlite:///var/lib/codimd/codimd.db";
    configuration.host = "0.0.0.0"; # just for testing purposes %) 
  };
  networking.firewall.allowedTCPPorts = [ 3000 ];
}

Oh and thanks a lot for your patience :D

@Ma27 Ma27 merged commit 69fab67 into NixOS:master Aug 20, 2019
@Ma27
Copy link
Member

Ma27 commented Aug 20, 2019

@WilliButz thanks 🎉

@WilliButz WilliButz deleted the update-codimd branch August 21, 2019 01:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ma27 Ma27 Ma27 approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@WilliButz @Ma27