[UserTimingL3] Add 'duration' member of PerformanceMeasureOptions. #18438
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
approved these changes
Aug 14, 2019
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-1753741
branch
2 times, most recently
from
22f7b4a
to
9827be2
Compare
In the User Timing L3 spec (https://w3c.github.io/user-timing/#performancemeasureoptions-dictionary), PerformanceMeasureOptions dictionaries can have a 'duration' member. This gives users better control over what timespan gets covered when calling `performance.measure()`. WPT coverage is also extended to check that user agents support the 'duration' member and raise errors as specified. Bug: 953848 Change-Id: Ibd2a9536b1688e19bebfd559dcf9f3437b7d89e7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1753741 Commit-Queue: Tom McKee <tommckee@chromium.org> Reviewed-by: Nicolás Peña Moreno <npm@chromium.org> Cr-Commit-Position: refs/heads/master@{#687391}
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-1753741
branch
from
9827be2
to
83cec94
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the User Timing L3 spec
(https://w3c.github.io/user-timing/#performancemeasureoptions-dictionary),
PerformanceMeasureOptions dictionaries can have a 'duration' member.
This gives users better control over what timespan gets covered when
calling
performance.measure().WPT coverage is also extended to check that user agents support the
'duration' member and raise errors as specified.
Bug: 953848
Change-Id: Ibd2a9536b1688e19bebfd559dcf9f3437b7d89e7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1753741
Commit-Queue: Tom McKee <tommckee@chromium.org>
Reviewed-by: Nicolás Peña Moreno <npm@chromium.org>
Cr-Commit-Position: refs/heads/master@{#687391}