Try to use SendCommandAndIgnoreResponse when dispatching events #18437
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
approved these changes
Aug 14, 2019
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-1752338
branch
2 times, most recently
from
9ac31a3
to
0bc67a5
Compare
We are proposing to use SendCommandAndIgnoreResponse to dispatch event to avoid waiting for the reply of sending events, so that we can dispatch more than one events in one tick. In order to control the time to send events we need to use tick duration for every tick, it can come from pause action or pointermove action. Adding it to pointermove is the simplest way to do it. We can also add pause for every action. Bug: 606367 Change-Id: Ib4745d37181de0724fe5e84fa32d893840ace910
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-1752338
branch
from
0bc67a5
to
205dcec
Compare
|
Close this PR because the Chromium CL does not have exportable changes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We are proposing to use SendCommandAndIgnoreResponse to dispatch event
to avoid waiting for the reply of sending events, so that we can
dispatch more than one events in one tick.
In order to control the time to send events we need to use tick
duration for every tick, it can come from pause action or pointermove
action. Adding it to pointermove is the simplest way to do it. We can
also add pause for every action.
Bug: 606367
Change-Id: Ib4745d37181de0724fe5e84fa32d893840ace910
Reviewed-on: https://chromium-review.googlesource.com/1752338
WPT-Export-Revision: 729b48faba2cce5bea35abc288b8d8e8914f63c4