Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

erlang: Fix build error on darwin #66651

Merged
merged 1 commit into from Aug 15, 2019
Merged

Conversation

lilyball
Copy link
Member

@lilyball lilyball commented Aug 14, 2019

Motivation for this change

Erlang stopped building on Darwin as a result of #64458 (which bumped MACOSX_DEPLOYMENT_TARGET). This is because it was hardcoding 10.10 as the detected platform.

Fixes #66644

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @the-kenny @sjmackenzie @couchemar @gleber


Build succeeded. I don't have any good way to test erlang offhand, but I did run result/bin/erl and got a REPL. I haven't tested the other executables.

Stop hardcoding 10.10 as the platform when building. Instead we'll use
$MACOSX_DEPLOYMENT_TARGET so erlang doesn't have to be updated again the
next time that's changed.
@couchemar
Copy link
Contributor

Looks good for me, but i have no MacOS to check

@Mic92
Copy link
Member

Mic92 commented Aug 15, 2019

@GrahamcOfBorg build erlang

@Mic92 Mic92 merged commit 31a577c into NixOS:master Aug 15, 2019
@lilyball lilyball deleted the erlang_darwin_10.12 branch August 16, 2019 07:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

erlang fails to build on macOS
3 participants