New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Media Capabilities: make framerate a double instead of a DOMString. #18440
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Already reviewed downstream.
b775c44
to
8dc4438
Compare
Spec change: w3c/media-capabilities#128 Bug: 994017 Change-Id: Iab036264fe19a6676c97bb12648321408d91f283 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1755046 Commit-Queue: Mounir Lamouri <mlamouri@chromium.org> Reviewed-by: Steven Holte <holte@chromium.org> Reviewed-by: Chrome Cunningham <chcunningham@chromium.org> Cr-Commit-Position: refs/heads/master@{#716773}
8dc4438
to
759c2ce
Compare
Looks like a slow test (on Chrome dev, at least):
I suspect the test was already slow based on the changes in content, and we had just been scraping the edge for a while. Need to check if its marked slow already - if not, then let's do that. In either case, will warn the author of the CL after we mark the test as slow. @KyleJu do you have bandwidth available to do that? |
Marked as a slow test and left a comment on the CL |
@KyleJu @stephenmcgruer how does "Running tests in a loop with restarts 5 times" translates in Chrome's web_tests runner? I can't reproduce this and I wonder if I don't use the right configs or if it's because WPT is using //chrome while we do not internally in Blink. @Rob--W @foolip FYI @chcunningham I wonder if the issue could be the loading of the DB assuming the above is correct and it can't be repro in Blink. |
Hey, sorry for the delay @mounirlamouri . "Running tests in a loop with restarts 5 times" would be approximately equivalent to passing Locally running this a few times, I got one result of 9.8 seconds which is close to the timeout, and one result of 10.6 that is over it:
Now I'm using a local build so not as fast as a release one (which is what wpt.fyi uses), but still a quite slow test! Also if you look at https://wpt.fyi/results/media-capabilities/decodingInfo.any.html?label=experimental&label=master&aligned, Chrome took 2.927 seconds to run this test file (on the run I looked at) vs 0.42 seconds for Firefox. |
Spec change: w3c/media-capabilities#128
Bug: 994017
Change-Id: Iab036264fe19a6676c97bb12648321408d91f283
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1755046
Commit-Queue: Mounir Lamouri <mlamouri@chromium.org>
Reviewed-by: Steven Holte <holte@chromium.org>
Reviewed-by: Chrome Cunningham <chcunningham@chromium.org>
Cr-Commit-Position: refs/heads/master@{#716773}