Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

luarocks: Update detected platform version #66653

Merged
merged 1 commit into from Aug 15, 2019

Conversation

lilyball
Copy link
Member

@lilyball lilyball commented Aug 14, 2019

Motivation for this change

Now that our MACOSX_DEPLOYMENT_TARGET is set to 10.12 (see #64458), we shouldn't be hardcoding the platform at build time as 10.10. This change makes it inherit the MACOSX_DEPLOYMENT_TARGET value.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @raskin @teto

Now that our MACOSX_DEPLOYMENT_TARGET is set to 10.12, we shouldn't be
hardcoding the platform at build time as 10.10. This change makes it
inherit the MACOSX_DEPLOYMENT_TARGET value.
@teto
Copy link
Member

teto commented Aug 15, 2019

@GrahamcOfBorg build luaPackages.neovim luaPackages.rapidjson

@teto
Copy link
Member

teto commented Aug 15, 2019

I had found the hardcoded value strange at the time but it fixed an urgent issue and I am no mac user. The fix looks ok, merging.

@teto teto merged commit 45e6253 into NixOS:master Aug 15, 2019
@lilyball lilyball deleted the luarocks_darwin_10.12 branch August 16, 2019 07:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants