New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[19.03] borgbackup: 1.1.9 -> 1.1.10 #66656
[19.03] borgbackup: 1.1.9 -> 1.1.10 #66656
Conversation
Semi-automatic update generated by https://github.com/ryantm/nixpkgs-update tools. This update was made based on information from https://repology.org/metapackage/borgbackup/versions (cherry picked from commit f4b8412)
https://github.com/borgbackup/borg/blob/1.1.10/docs/changes.rst#version-1110-2019-05-16 mentions borgbackup now shipping a supported msgpack-python release, and strongly encourages using that one. So don't pass any msgpack-python into the build, and use the provided one. (cherry picked from commit 5d4b383)
Is there a particular motivation for back porting (e.g. security issue, severe bugs)? |
@markuskowa It's a bug-fix release, so it'll depend on your definition of "severe", I guess. Somebody please explain to me the meaning of "stable release" here: Even minor-upgrade only when air is on fire? My understanding would be that "upgrade to a more recent minor version" would be okay resp. worthwhile, as upstream might be reasonable (I wouldn't have PR'ed for a major version upgrade in most cases, though, for obvious reasons). |
I guess the policy on back ports is not really fixed. The nixpkgs manual does not clarify it and the [PR for RFC 29] (https://github.com/NixOS/rfcs/pull/29/files) was closed. This one here may serve as a guideline. In my reading a patch level update should not be automatically back ported unless it contains security bug fixes, the present version is broken, or has bugs that impairs it functionality. Someone saying "this patch level update fixes an annoying little bug" would be good enough for me. As part of the review process it is legitimate to ask why something should be back ported. A link to the change log (or to the original PR on master) would also help here to judge what bugs are actually fixed. @grahamc Do you have any comment on patch level update back ports? |
Okay, thanks. The changelog is here. As I'm intending to have a borg server running on the internet™, the point about hanging servers on certain extract operations sounded relevant to me. For reasons of "intend" I cannot claim to be directly affected, though. |
@GrahamcOfBorg test borgbackup |
Motivation for this change
Update to current minor version.
Things done
sandbox
in [nix.conf
](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
nix-shell -p nix-review --run "nix-review wip"
./result/bin/
)nix path-info -S
before and after)Notify maintainers