Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[19.03] borgbackup: 1.1.9 -> 1.1.10 #66656

Merged
merged 2 commits into from Aug 17, 2019

Conversation

herrwiese
Copy link
Contributor

Motivation for this change

Update to current minor version.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in [nix.conf](http://nixos.org/nix/manual/#sec-
    conf-file) on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

r-ryantm and others added 2 commits August 15, 2019 01:50
Semi-automatic update generated by
https://github.com/ryantm/nixpkgs-update tools. This update was made
based on information from
https://repology.org/metapackage/borgbackup/versions

(cherry picked from commit f4b8412)
https://github.com/borgbackup/borg/blob/1.1.10/docs/changes.rst#version-1110-2019-05-16
mentions borgbackup now shipping a supported msgpack-python release, and
strongly encourages using that one.

So don't pass any msgpack-python into the build, and use the provided
one.

(cherry picked from commit 5d4b383)
@markuskowa
Copy link
Member

Is there a particular motivation for back porting (e.g. security issue, severe bugs)?

@herrwiese
Copy link
Contributor Author

@markuskowa It's a bug-fix release, so it'll depend on your definition of "severe", I guess. Somebody please explain to me the meaning of "stable release" here: Even minor-upgrade only when air is on fire? My understanding would be that "upgrade to a more recent minor version" would be okay resp. worthwhile, as upstream might be reasonable (I wouldn't have PR'ed for a major version upgrade in most cases, though, for obvious reasons).

@markuskowa
Copy link
Member

I guess the policy on back ports is not really fixed. The nixpkgs manual does not clarify it and the [PR for RFC 29] (https://github.com/NixOS/rfcs/pull/29/files) was closed. This one here may serve as a guideline. In my reading a patch level update should not be automatically back ported unless it contains security bug fixes, the present version is broken, or has bugs that impairs it functionality. Someone saying "this patch level update fixes an annoying little bug" would be good enough for me. As part of the review process it is legitimate to ask why something should be back ported. A link to the change log (or to the original PR on master) would also help here to judge what bugs are actually fixed.

@grahamc Do you have any comment on patch level update back ports?

@herrwiese
Copy link
Contributor Author

Okay, thanks. The changelog is here. As I'm intending to have a borg server running on the internet™, the point about hanging servers on certain extract operations sounded relevant to me. For reasons of "intend" I cannot claim to be directly affected, though.

@markuskowa
Copy link
Member

markuskowa commented Aug 15, 2019

@GrahamcOfBorg test borgbackup
@GrahamcOfBorg build borgbackup

@markuskowa markuskowa merged commit a417973 into NixOS:release-19.03 Aug 17, 2019
@herrwiese herrwiese deleted the borgbackup-1.1.10-19.03 branch August 19, 2019 11:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants