Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use correct openxr loader path for x64 #23977

Merged
merged 1 commit into from Aug 16, 2019
Merged

Use correct openxr loader path for x64 #23977

merged 1 commit into from Aug 16, 2019

Conversation

jdm
Copy link
Member

@jdm jdm commented Aug 15, 2019 •
edited by SimonSapin

This change is Reviewable

@highfive
Copy link

Heads up! This PR modifies the following files:

@highfive highfive added the S-awaiting-review There is new code that needs to be reviewed. label Aug 15, 2019
@jdm
Copy link
Member Author

jdm commented Aug 15, 2019

r? @Manishearth

@highfive highfive assigned Manishearth and unassigned avadacatavra Aug 15, 2019
@Manishearth
Copy link
Member

@bors-servo r+

@bors-servo
Copy link
Contributor

📌 Commit 4c79227 has been approved by Manishearth

@highfive highfive added S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. and removed S-awaiting-review There is new code that needs to be reviewed. labels Aug 15, 2019
bors-servo pushed a commit that referenced this pull request Aug 16, 2019
Auto merge of #23977 - servo:jdm-patch-46, r=Manishearth
619c763 
Use correct openxr loader path for x64

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/23977)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

⌛ Testing commit 4c79227 with merge 619c763...

@bors-servo
Copy link
Contributor

💔 Test failed - status-taskcluster

@highfive highfive added S-tests-failed The changes caused existing tests to fail. and removed S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. labels Aug 16, 2019
@jdm
Copy link
Member Author

jdm commented Aug 16, 2019

@bors-servo retry

  • builder timed out because of stale test process

@bors-servo
Copy link
Contributor

💣 Failed to start rebuilding: Unknown error

@bors-servo
Copy link
Contributor

⌛ Testing commit 4c79227 with merge ec2ca08...

bors-servo pushed a commit that referenced this pull request Aug 16, 2019
Auto merge of #23977 - servo:jdm-patch-46, r=Manishearth
ec2ca08 
Use correct openxr loader path for x64

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/23977)
<!-- Reviewable:end -->
@highfive highfive added S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. and removed S-tests-failed The changes caused existing tests to fail. labels Aug 16, 2019
@bors-servo
Copy link
Contributor

☀️ Test successful - linux-rel-css, linux-rel-wpt, status-taskcluster
Approved by: Manishearth
Pushing ec2ca08 to master...

@bors-servo bors-servo merged commit 4c79227 into master Aug 16, 2019
@highfive highfive removed the S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. label Aug 16, 2019
@SimonSapin SimonSapin deleted the jdm-patch-46 branch September 30, 2019 15:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@Manishearth Manishearth

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@jdm @highfive @Manishearth @bors-servo @avadacatavra