Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

httplz: 1.5.0 -> 1.5.1 #66726

Merged
merged 2 commits into from Aug 17, 2019
Merged

httplz: 1.5.0 -> 1.5.1 #66726

merged 2 commits into from Aug 17, 2019

Conversation

bbigras
Copy link
Contributor

@bbigras bbigras commented Aug 16, 2019

Motivation for this change

It's a minor update, it only updates the hyper-native-tls Rust dependency.
https://github.com/thecoshman/http/releases/tag/v1.5.1

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

nix path-info -Sh ./result
/nix/store/gfgd5kwpb6gxb1a61dlma71dyyqkhj73-httplz-1.5.0 35.5M

nix path-info -Sh ./result
/nix/store/d3c2xzwynkwf8jlidp53psymqi5fx7bz-httplz-1.5.1 35.5M

Notify maintainers

@mmahut
Copy link
Member

mmahut commented Aug 16, 2019

@GrahamcOfBorg build httplz

@bbigras
Copy link
Contributor Author

bbigras commented Aug 17, 2019

@mmahut thanks

@mmahut
Copy link
Member

mmahut commented Aug 17, 2019

@GrahamcOfBorg build httplz

Copy link
Member

@mmahut mmahut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • reviewed the diff and commit messages
  • made sure ofBorg build succeeded for all applicable platforms
  • run nix-review without any failures
  • run and tested the binaries

@mmahut mmahut merged commit 4291d44 into NixOS:master Aug 17, 2019
@bbigras bbigras deleted the httplz branch August 17, 2019 21:44
@bbigras
Copy link
Contributor Author

bbigras commented Aug 17, 2019

Tyvm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants