Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: NixOS/nixpkgs
base: 332a46b125ce
Choose a base ref
...
head repository: NixOS/nixpkgs
compare: f426173e30d2
Choose a head ref
  • 1 commit
  • 1 file changed
  • 1 contributor

Commits on Aug 16, 2019

  1. bazel: Fix python stub template 

    The shebang in the python stub template was incorrectly patched to
```
<store-path>/bin/env python
```
instead of
```
<store-path>/bin/python
```

The reason was that `patchShebangs` was called with `--replace` which is
an unknown argument.
```
patching script interpreter paths in src/main/java/com/google/devtools/build/lib/bazel/rules/python/python_stub_template.txt --replace /usr/bin/env python /nix/store/w7gsq8v86hni4ynaqgwwlnlny115ylng-python3-3.7.4/bin/python
find: unknown predicate `--replace'
```

Using `substituteInPlace` instead resolves that issue.

The wrong shebang caused failures of `py_binary` targets due to `python`
not being in `PATH` in certain circumstances.
    @aherrmann @Profpatsch
    aherrmann authored and Profpatsch committed Aug 16, 2019
    Copy the full SHA
    f426173 View commit details
    Browse the repository at this point in the history