New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
rstudio: fix build #66670
rstudio: fix build #66670
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nix-review
passes on NixOS
diff LGTM
Not really related to the goal of the PR but, I don't like the implications of the rstudioWrapper for this package. If someone wants to install RStudio (gui), AND use some of the other binaries, they can't without having package conflicts.
$ nix-env -f ./nixpkgs/ -iA rstudio -iA rstudioWrapper
installing 'RStudio-1.2.1335'
installing 'RStudio-1.2.1335-wrapper'
building '/nix/store/fwnv4i16qngwxw75w4qb3d3ggjxpwp4g-user-environment.drv'...
error: packages '/nix/store/v5avxdcq94ar8m5m93x13zjni5xriqqw-RStudio-1.2.1335-wrapper/bin/rstudio' and '/nix/store/0vsrmdk0x8b9q51bqw0imn18mp2v90hd-RStudio-1.2.1335/bin/rstudio' have the same priority 5; use 'nix-env --set-flag priority NUMBER INSTALLED_PKGNAME' to change the priority of one of the conflicting packages (0 being the highest priority)
builder for '/nix/store/fwnv4i16qngwxw75w4qb3d3ggjxpwp4g-user-environment.drv' failed with exit code 1
error: build of '/nix/store/fwnv4i16qngwxw75w4qb3d3ggjxpwp4g-user-environment.drv' failed
I feel like the Wrapped version (at the very least) should be re-exporting the binaries, so that you can do either one or the other, but don't need both
The wrapper installs rstudio. I only have |
I'm referencing the fact that the base rstudio package has an rstudio executable, which can't be ran:
|
I think it's just not meant to be run that way, you don't have any packages. The plugin wrapping was done in the wrapper even before the recent #65399 stuff too, although I guess that could be moved if there was an actual use-case. |
Getting a conflict again, on the current master
|
Motivation for this change
Aliases for hunspell dicts from #65349 in ed06097 make this derivation fail, so we just use unique values.
No rebuild, as the old cached result remains valid.Things done
sandbox
innix.conf
on non-NixOS)nix-shell -p nix-review --run "nix-review wip"
./result/bin/
)nix path-info -S
before and after)Notify maintainers
cc @matthewbauer