-
Notifications
You must be signed in to change notification settings - Fork 69
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Test orbit analysis on real orbits #2284
Conversation
Ephemeris<ICRS>::FixedStepParameters( | ||
SymmetricLinearMultistepIntegrator<QuinlanTremaine1990Order12, | ||
Position<ICRS>>(), | ||
/*step=*/1 * JulianYear))), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One year? Really?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added a comment.
|
||
SolarSystem<ICRS> earth_1957_; | ||
not_null<std::unique_ptr<Ephemeris<ICRS>>> ephemeris_; | ||
RotatingBody<ICRS> const& earth_; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No oblateness?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We have no need to know about the properties of the oblateness here.
Property(&OrbitRecurrence::Dᴛₒ, 0), | ||
Property(&OrbitRecurrence::Cᴛₒ, 1))); | ||
EXPECT_THAT(elements.mean_semimajor_axis_interval().midpoint(), | ||
IsNear(42'166 * Kilo(Metre))); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do these numbers come from some reference document? Can you give references? Same questions everywhere.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I give references where they do come from some reference document; where they do not, they are just the truncation of whatever the test spat out.
This will be made clearer once we have the new matchers: we can use
IsNear(12'345_⑴ * Kilo(Metre))
for the change-detector tests, and
AbsoluteErrorFrom(12'345 * Kilo(Metre), IsNear(3.2_⑴ * Kilo(Metre)))
where we have nominal values.
And find, and fix, a bug.