Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

graylog: 3.0.2 -> 3.1.0 #66754

Merged
merged 1 commit into from Aug 17, 2019
Merged

graylog: 3.0.2 -> 3.1.0 #66754

merged 1 commit into from Aug 17, 2019

Conversation

fadenb
Copy link
Contributor

@fadenb fadenb commented Aug 17, 2019

Motivation for this change

New features (some enterprise only functionality is now available in the open-source version 馃帀 )

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @Ma27

@Ma27
Copy link
Member

Ma27 commented Aug 17, 2019

@GrahamcOfBorg test graylog

@fadenb
Copy link
Contributor Author

fadenb commented Aug 17, 2019

@Ma27 the test run by grahamcofborg timed out:

machine# [  430.822295] systemd[1]: graylog.service: Start-pre operation timed out. Terminating.
machine# [  430.893546] systemd[1]: graylog.service: Control process exited, code=killed, status=15/TERM
machine# [  430.947447] systemd[1]: graylog.service: Failed with result 'timeout'.
machine# [  431.041879] systemd[1]: Failed to start Graylog Server.

locally it seems to succeed

@Ma27
Copy link
Member

Ma27 commented Aug 17, 2019

Yeah... after scheduling the ofborg task I suddenly remembered that the nix.ci infra appears to lack resources to properly run this test 馃槄 (not a criticism or complaint though, I knew about the problems when writing the test, as long as it's relatively stable, I'm perfectly happy, I just forgot about the issue ^^)

I'll check it locally as well (can take some time though as I'm actually on vacation and have a rather poor uplink ^^), after that it should good to go 馃憤

@Ma27
Copy link
Member

Ma27 commented Aug 17, 2019

On a side-note: the test appears to run fine on Hydra: https://hydra.nixos.org/job/nixos/trunk-combined/nixos.tests.graylog.x86_64-linux

So as long as this problem only occurs on ofborg, this should be fine.

Ma27
Ma27 approved these changes Aug 17, 2019
View reviewed changes
Copy link
Member

@Ma27 Ma27 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested locally, seems fine 馃憤

@Ma27 Ma27 merged commit 1f2b0f6 into NixOS:master Aug 17, 2019
@Ma27
Copy link
Member

Ma27 commented Aug 17, 2019

@fadenb thanks!

@fadenb fadenb deleted the graylog_3.1.0 branch August 17, 2019 15:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ma27 Ma27 Ma27 approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@fadenb @Ma27