Fix interpolation-testcommon.js on Firefox #18508
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
approved these changes
Aug 16, 2019
The new test generation logic had some problems: i. It produced different sets of tests on different browsers depending on the support status. This caused difficulties comparing test results across browsers. ii. It produced duplicate subtest names when a 'from', 'to', or 'underlying' was not supported. Duplicate subtests are a fatal error in WPT. This CL fixes these problems by always generating the tests, and asserting support in them. It also removes the composition code, which was unused. Bug: 900581 Change-Id: Id5617881bbf3b5f0a0b8eade5b630aa8fd65af8a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1758486 Commit-Queue: Stephen McGruer <smcgruer@chromium.org> Reviewed-by: Robert Ma <robertma@chromium.org> Cr-Commit-Position: refs/heads/master@{#687797}
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-1758486
branch
from
26ff488
to
f221d95
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The new test generation logic had some problems:
i. It produced different sets of tests on different browsers depending
on the support status. This caused difficulties comparing test results
across browsers.
ii. It produced duplicate subtest names when a 'from', 'to', or
'underlying' was not supported. Duplicate subtests are a fatal error
in WPT.
This CL fixes these problems by always generating the tests, and
asserting support in them.
It also removes the composition code, which was unused.
Bug: 900581
Change-Id: Id5617881bbf3b5f0a0b8eade5b630aa8fd65af8a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1758486
Commit-Queue: Stephen McGruer <smcgruer@chromium.org>
Reviewed-by: Robert Ma <robertma@chromium.org>
Cr-Commit-Position: refs/heads/master@{#687797}