Reword test names generated by interpolation-testcommon.js #18507
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously the generated test names were of the form: property foo from <value> to <value> at <progress> is <actual-value> This read weirdly when the test failed: property foo from 0 to 1 at 0.5 is 'bananas': expected 0.5 but got 'bananas' This CL re-words the test names to read like: property foo from 0 to 1 at 0.5 should be 0.5: expected 0.5 but got 'bananas' Bug: 900581 Change-Id: I77a02a24648171b3945d41cbf81d982879f4500d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1758283 Reviewed-by: Xida Chen <xidachen@chromium.org> Commit-Queue: Stephen McGruer <smcgruer@chromium.org> Cr-Commit-Position: refs/heads/master@{#687653}
wpt-pr-bot
approved these changes
Aug 16, 2019
|
Error is not caused by this PR and will be fixed by https://chromium-review.googlesource.com/c/chromium/src/+/1758486 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously the generated test names were of the form:
property foo from <value> to <value> at <progress> is <actual-value>
This read weirdly when the test failed:
property foo from 0 to 1 at 0.5 is 'bananas': expected 0.5 but got 'bananas'
This CL re-words the test names to read like:
property foo from 0 to 1 at 0.5 should be 0.5: expected 0.5 but got 'bananas'
Bug: 900581
Change-Id: I77a02a24648171b3945d41cbf81d982879f4500d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1758283
Reviewed-by: Xida Chen <xidachen@chromium.org>
Commit-Queue: Stephen McGruer <smcgruer@chromium.org>
Cr-Commit-Position: refs/heads/master@{#687653}