[tools] Disallow refs to some non-existent files #18509
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The Chromium infrastructure generates files which it stores in a top-level directory named "gen". In the absence of stable documentation for how these files must be implemented, the tests which reference them cannot be used by other implementations.
jgraham
approved these changes
Aug 20, 2019
| @@ -350,6 +350,13 @@ class LayoutTestsRegexp(Regexp): | |||
| file_extensions = [".html", ".htm", ".js", ".xht", ".xhtml", ".svg"] | |||
| description = "eventSender/testRunner/internals used; these are LayoutTests-specific APIs (WebKit/Blink)" | |||
|
|
|||
| class MissingDepsRegexp(Regexp): | |||
| pattern = br"[^\w]/gen/" | |||
There was a problem hiding this comment.
Hmm so in theory we can probably do better than a regexp here, but it's also likely not worth it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Chromium infrastructure generates files which it stores in a
top-level directory named "gen". In the absence of stable documentation
for how these files must be implemented, the tests which reference them
cannot be used by other implementations.