Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

kubeless: init at 1.0.4 #66720

Merged
merged 2 commits into from Aug 22, 2019
Merged

kubeless: init at 1.0.4 #66720

merged 2 commits into from Aug 22, 2019

Conversation

00-matt
Copy link
Contributor

@00-matt 00-matt commented Aug 16, 2019 •
edited

Motivation for this change

Adds the kubeless command for interacting with functions running on top of Kubernetes.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

srhb
srhb requested changes Aug 22, 2019
View reviewed changes
Copy link
Contributor

@srhb srhb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution!

If you add something like:

  buildFlagsArray = ''
    -ldflags=
      -X github.com/kubeless/kubeless/pkg/version.Version=${version}
  '';

kubeless version will display the correct version instead of an empty string. :)

maintainers/maintainer-list.nix Show resolved Hide resolved
@ofborg ofborg bot removed the 6.topic: golang label Aug 22, 2019
@00-matt
Copy link
Contributor Author

00-matt commented Aug 22, 2019

Thanks for the version tip. Updated that and fixed the entry in the maintainers list :)

@srhb
Copy link
Contributor

srhb commented Aug 22, 2019

Great! I'll merge as soon as OfBorg gives the A-OK. Thanks again! 😸

@mmahut
Copy link
Member

mmahut commented Aug 22, 2019

@GrahamcOfBorg build kubeless

@srhb srhb merged commit a6292c8 into NixOS:master Aug 22, 2019
@00-matt 00-matt deleted the pkg-kubeless branch August 22, 2019 21:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@srhb srhb srhb approved these changes

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 12. first-time contribution
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@00-matt @srhb @mmahut @FRidh @Janik-Haag