New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
rename iso_graphical to iso_plasma5 #66640
Conversation
Coordinate with NixOS/nixpkgs#66640
Coordinate with NixOS/nixpkgs#66640
5795873
to
473fb33
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 for the more specific name.
Not in favor of this because it's sufficient to provide 1 graphical ISO and this would open the floodgates to ISOs for every desktop environment out there. Also having multiple ISOs makes testing harder. |
So it would be interesting to know what the size of a combined Plasma + Gnome ISO is. Presumably it's quite a bit less than the separate ISOs. |
Maybe ISO (and other image) generation should be moved out of the main jobsets into a jobset that runs at a lower frequency. After all, channel users don't really care whether the ISOs built correctly, so ISOs don't need to be a channel blocker. |
That sounds perfect ✨ |
@edolstra while I definitely don't think NixOS should have an ISO for every single desktop environment out there... you had made the valid counterpoint to this (during #officehours) that gnome and kde are the primary desktop environments, and have been for many years now... so it isn't hard to draw the line at kde plus gnome, with no more ISOs after that. Let us keep in mind that we are all very technical people who know how to work with NixOS to get exactly what we want, but our knowledge and ability does not represent the majority of nix users, nor does it represent people who we want to become NixOS users. When people in the community put an effort forward to improve the UX, especially for new users, I think we should see what we can do to encourage and help that. That being said, let me know if there is any help I can provide you with on this effort @worldofpeace! Thanks for thinking about new and potential users and the positive experience we want them to have ❤️ |
Thank you @aanderse ✨ I really do appreciate your perspective. The following is just the general thoughts floating around in my headI also want to note that someone is or should be responsible that GNOME in nixpkgs is suitable for production on users machines, and honestly has been part of the Release Engineering process. I'd say from my experience improving this and user feedback it's extremely suitable for an ISO in distribution, I'm already responsible for GNOME's user experience. If we need policies for what desktop environments should be marked as officially supported in nixpkgs we should have that. I'd suggest a form of a group, comprised of
And people who can be responsible for the final say like you. I'd also like to address the concern of people not knowing which ISO to choose. This is nice but adds a pretty serious level of ambiguity to users, this is why Fedora for example has "Spins" and Ubuntu's default is now GNOME but there's still things like Kubuntu or Ubuntu Mate. |
A random though that occurred: using a graphical iso (or session) should pre-seed the configuration.nix with the configuration for that DE. This would add value to having the additional DE, as this allows the end-user to test the DE, and have a reasonable assumption that once it is installed it will run as it did with the installer media. Though, this does imply more work to get there. |
That's an excellent idea, and intuitive. And it looks like there might be a way put this together because of 810388a. Or at least clear how to add this. You'd have a configuration seed/switch for
A followup to definitely consider. |
473fb33
to
c4c0ee9
Compare
c4c0ee9
to
600377a
Compare
So, two months later and a nixos release... I think we could go for this in 20.03, and as stated, I'm completely willing do whatever I can to have this within my abilities. And of course with the co-operation of my peers. |
I like the direction this discussion is going! Some thoughts: Why not call the ISOs |
I kinda agree, but the nixos options are
And that particular nixos configuration is what differentiates these artifacts, so I think it's best we name them by this. |
600377a
to
30e1a8f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Coordinate with NixOS/nixpkgs#66640
And all the other things and paths to match it
30e1a8f
to
0f2536f
Compare
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: |
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: https://discourse.nixos.org/t/considering-new-installation-approaches/17778/2 |
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: https://discourse.nixos.org/t/considering-new-installation-approaches/17778/11 |
Motivation for this change
In the upcoming possibility of there being an
iso_graphical_gnome3
renamingiso_graphical
to
iso_graphical_plasma5
is needed because there could be multipleiso_graphical
's.I've been informed that changing this will require updating the channel generation script and website.
Please merge with
Things done
sandbox
innix.conf
on non-NixOS)nix-shell -p nix-review --run "nix-review wip"
./result/bin/
)nix path-info -S
before and after)