Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

emacsPackagesNg.emacsql-sqlite: Build sqlite binary #66642

Merged
merged 1 commit into from Aug 15, 2019
Merged

emacsPackagesNg.emacsql-sqlite: Build sqlite binary #66642

merged 1 commit into from Aug 15, 2019

Conversation

etu
Copy link
Contributor

@etu etu commented Aug 14, 2019

Motivation for this change

Build and install the sqlite binary under a name and location that the elisp code picks up without the need to patch the elisp code.

Without this libraries like magit breaks and helm behaves very badly.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

@etu etu requested a review from adisbladis August 14, 2019 20:44
@matthewbauer
Copy link
Member

Can you also add "stripDebugList" like was done here: 62e61b9

@etu etu force-pushed the emacspackagesng-emacsql-fix-sqlite branch from 6b9ebe7 to 9c3b15d Compare August 15, 2019 05:23
@etu
Copy link
Contributor Author

etu commented Aug 15, 2019 •
edited

Currently this actually doesn't fully work, the binary is there in the result, but the elisp code doesn't find it. I think I know why and working on it. So no merge yet.

Ok, heard that it may be a good idea to override the right package. It works now :)

@etu etu force-pushed the emacspackagesng-emacsql-fix-sqlite branch from 9c3b15d to c8fe8a0 Compare August 15, 2019 05:51
@etu etu changed the title emacsPackagesNg.emacsql: Build sqlite binary emacsPackagesNg.emacsql-sqlite: Build sqlite binary Aug 15, 2019
@etu etu force-pushed the emacspackagesng-emacsql-fix-sqlite branch from c8fe8a0 to ce60bca Compare August 15, 2019 05:53
@adisbladis adisbladis merged commit 2f1cb20 into NixOS:master Aug 15, 2019
@etu etu deleted the emacspackagesng-emacsql-fix-sqlite branch August 16, 2019 14:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adisbladis adisbladis Awaiting requested review from adisbladis

Assignees
No one assigned
Labels
6.topic: emacs 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@etu @matthewbauer @adisbladis