New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
rename iso_graphical to iso_plasma5 #25
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
contingent on NixOS/nixpkgs#66640
How will it work with "mixed channels", e.g. the span up to the EOL of 19.03? We'll have updates for both 19.03 and 19.09/unstable going on, with a different sent of images being generated. |
Perhaps we backport all of the renames? |
We should probably not backport renames, as that is a pretty big change which somebody might have built against.
|
Hrm. Using |
Yep, and I think the script will need this in the future if the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(great points raised)
(light bikeshedding warning) It would be great if the release could define artifacts, and that definition be used to generate the page, instead of making it in the script. This would ensure future additions (hint: aarch64 releases?) to be done without having to hack around in the publishing script. |
e72e5c7 maybe does the things? |
Here's my 1:1 replica of the bikeshed, with the colour applied to it The main idea being that there's a job added to the channels, listing job names that will be published by the release script. (Except for pre-19.09 releases, where it uses the fixed manifest equivalent.) Here are things I don't like from my first draft:
And the things I think might ruffle some feathers:
I am not attached to the implementation, though I think the concept is sound. Let's make each released channels describe their own "publishables". @edolstra your input would be appreciated. I think this is generally the right direction, but it would be nice to have some advice, and your opinion, about the best way to handle the concept. Thanks! |
e72e5c7
to
4854c79
Compare
4854c79
to
9c17476
Compare
9c17476
to
1ba94a5
Compare
1ba94a5
to
7514095
Compare
Coordinate with NixOS/nixpkgs#66640