Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

antlr4: 4.7.1 -> 4.7.2 #66643

Merged
merged 3 commits into from Oct 6, 2019
Merged

antlr4: 4.7.1 -> 4.7.2 #66643

merged 3 commits into from Oct 6, 2019

Conversation

jonringer
Copy link
Contributor

Motivation for this change

fixing updates @r-ryantm cannot.

patched mysqlWorkbench so it looked for the new version as well.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

$ nix path-info -Sh ./result
/nix/store/hh7mfax21dkp0cb6fr4hjc9cax558mlm-antlr-4.7.2  380.1M
$ nix path-info -Sh ./result
/nix/store/f1pwavzhbi3xlk1468syaykw8aqq2x5l-antlr-4.7.1  380.2M

@jonringer jonringer changed the title Bump antlr4 antlr4: 4.7.1 -> 4.7.2 Aug 14, 2019
@jonringer jonringer requested a review from FRidh as a code owner August 14, 2019 21:27
@jonringer
Copy link
Contributor Author

@GrahamcOfBorg build antlr4 mysqlWorkbench python27Packages.antlr4-python2-runtime python27Packages.azure-cli-core python37Packages.antlr4-python3-runtime python37Packages.azure-cli-core

@jonringer
Copy link
Contributor Author

@GrahamcOfBorg build antlr4 mysqlWorkbench python27Packages.antlr4-python2-runtime python27Packages.azure-cli-core python37Packages.antlr4-python3-runtime python37Packages.azure-cli-core

1 similar comment
@mmahut
Copy link
Member

mmahut commented Aug 24, 2019

@GrahamcOfBorg build antlr4 mysqlWorkbench python27Packages.antlr4-python2-runtime python27Packages.azure-cli-core python37Packages.antlr4-python3-runtime python37Packages.azure-cli-core

@disassembler
Copy link
Member

building workbench locally as it's timing out because of build time it takes.

@jonringer
Copy link
Contributor Author

@GrahamcOfBorg build antlr4 python27Packages.antlr4-python2-runtime python27Packages.azure-cli-core python37Packages.antlr4-python3-runtime python37Packages.azure-cli-core

@jonringer
Copy link
Contributor Author

@mmahut I left out mysqlworkbench, as it times out on ofborg, I did test it locally and it at least launches and seems to be working fine.

@mmahut
Copy link
Member

mmahut commented Aug 26, 2019

@GrahamcOfBorg build antlr4 python27Packages.antlr4-python2-runtime python27Packages.azure-cli-core python37Packages.antlr4-python3-runtime python37Packages.azure-cli-core

@jonringer
Copy link
Contributor Author

@GrahamcOfBorg build antlr4 python27Packages.antlr4-python2-runtime python27Packages.azure-cli-core python37Packages.antlr4-python3-runtime python37Packages.azure-cli-core

@jonringer
Copy link
Contributor Author

bump :) @mmahut @marsam

@jonringer
Copy link
Contributor Author

also, cc @FRidh as it includes two python packages

@marsam marsam merged commit 03a5cf8 into NixOS:master Oct 6, 2019
@marsam
Copy link
Contributor

marsam commented Oct 6, 2019

@jonringer thanks for working on this

@jonringer jonringer deleted the bump-antlr4 branch February 13, 2020 01:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FRidh FRidh Awaiting requested review from FRidh

Assignees
No one assigned
Labels
6.topic: python 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@jonringer @mmahut @disassembler @marsam