xmrig{,-proxy}: 2.14.4 -> 3.0.0, add build options customization #66646
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
See the automated #76476 - you may want to suggest closing it in favor of this. |
aij
reviewed
Feb 23, 2020
| ++ lib.optional ((lib.count(a: a == "cryptonight-heavy") algo) == 0) "-DWITH_CN_HEAVY=OFF" | ||
| ++ lib.optional ((lib.count(a: a == "cryptonight-pico") algo) == 0) "-DWITH_CN_PICO=OFF" | ||
| ++ lib.optional ((lib.count(a: a == "cryptonight-gpu") algo) == 0) "-DWITH_CN_GPU=OFF" | ||
| ++ lib.optional ((lib.count(a: a == "randomx") algo) == 0) "-DWITH_RANDOMX=OFF" |
There was a problem hiding this comment.
It would be better if this would fail for unknown algo values, so that typos would result in errors instead of silently being ignored.
Also, I think explicitly passing =ON or =OFF would be better in case upstream defaults change in the future.
| }; | ||
|
|
||
| cmakeFlags = [] | ||
| ++ lib.optional (!tls) "-DWITH_TLS=OFF" |
There was a problem hiding this comment.
Here too
cmakeFlags = [ "-DWITH_TLS=${if tls then "ON" else "OFF"}" ];
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update versions and add build customization, incl. choosing your own algorithms to compile.
Things done
sandboxinnix.confon non-NixOS)nix-shell -p nix-review --run "nix-review wip"./result/bin/)nix path-info -Sbefore and after)Notify maintainers
cc @aij @fpletz