Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pythonPackages.furl #66675

Merged
merged 2 commits into from Feb 9, 2020
Merged

pythonPackages.furl #66675

merged 2 commits into from Feb 9, 2020

Conversation

vanzef
Copy link
Contributor

@vanzef vanzef commented Aug 15, 2019

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

@vanzef vanzef requested a review from FRidh as a code owner August 15, 2019 12:35
@vanzef
Copy link
Contributor Author

vanzef commented Aug 15, 2019

@jonringer, thanks for suggestions, I've applied them all.

jonringer
jonringer approved these changes Aug 15, 2019
View reviewed changes
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nix-review passes on NixOS
diff LGTM

[7 built, 10 copied (2.5 MiB), 0.5 MiB DL]
https://github.com/NixOS/nixpkgs/pull/66675
4 package were build:
python27Packages.furl python27Packages.orderedmultidict python37Packages.furl python37Packages.orderedmultidict

@risicle
Copy link
Contributor

risicle commented Aug 16, 2019

nix-review is happy for me on macos 10.13.

@FRidh FRidh merged commit f4f450f into NixOS:master Feb 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonringer jonringer jonringer approved these changes

@FRidh FRidh Awaiting requested review from FRidh

Assignees
No one assigned
Labels
6.topic: python 8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@vanzef @risicle @jonringer @FRidh