[LargestContentfulPaint] Add larger content tests #18472
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
approved these changes
Aug 15, 2019
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-1757165
branch
from
b1ef0c8
to
57b7bd4
Compare
This CL adds tests where there is a bunch of content and LCP must observe the largest (one for when image is largest, one for text). Bug: 994414 Change-Id: I9330f238e1f8a2a8227dce7a04fd741d2dc666d7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1757165 Reviewed-by: Steve Kobes <skobes@chromium.org> Commit-Queue: Nicolás Peña Moreno <npm@chromium.org> Cr-Commit-Position: refs/heads/master@{#688087}
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-1757165
branch
from
57b7bd4
to
5bf819d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This CL adds tests where there is a bunch of content and LCP must observe the
largest (one for when image is largest, one for text).
Bug: 994414
Change-Id: I9330f238e1f8a2a8227dce7a04fd741d2dc666d7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1757165
Reviewed-by: Steve Kobes <skobes@chromium.org>
Commit-Queue: Nicolás Peña Moreno <npm@chromium.org>
Cr-Commit-Position: refs/heads/master@{#688087}