Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pry: init at 0.12.2 #66699

Merged
merged 1 commit into from Jan 9, 2020
Merged

pry: init at 0.12.2 #66699

merged 1 commit into from Jan 9, 2020

Conversation

tckmn
Copy link
Member

@tckmn tckmn commented Aug 16, 2019

Motivation for this change

Adding the pry package.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@peterhoeg
Copy link
Member

Would you use pry on its own? I'd only ever used it as part of another project.

@tckmn
Copy link
Member Author

tckmn commented Aug 16, 2019

I've only ever used pry as a REPL (as a replacement for irb).

@Mic92 Mic92 requested a review from zimbatm August 16, 2019 05:51
@peterhoeg peterhoeg merged commit 2e05653 into NixOS:master Jan 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants